Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Create-alarabiya.net.xml - #7506

Merged
jeremyn merged 16 commits into
masterfrom
unknown repository
Nov 5, 2016
Merged

jeremyn merged 16 commits into
masterfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Nov 4, 2016

Copy link
Copy Markdown

The english.alarabiya.net seem to use https by default. enawafeth.alarabiya.net was not included because SSL_ERROR_BAD_CERT_DOMAIN error.
https://www.ssllabs.com/ssltest/analyze.html?d=enawafeth.alarabiya.net&s=68.142.93.254&ignoreMismatch=on
https://www.ssllabs.com/ssltest/analyze.html?d=enawafeth.alarabiya.net&s=68.142.93.133&ignoreMismatch=on

Also urdu.alarabiya.net have some mixed content on page due to alarabiya.net ( https://imgur.com/YVZXO4d ), but that should be fixed by adding alarabiya.net to the list, right?

The english.alarabiya.net seem to use https by default. enawafeth.alarabiya.net was not included because SSL_ERROR_BAD_CERT_DOMAIN error. 
https://www.ssllabs.com/ssltest/analyze.html?d=enawafeth.alarabiya.net&s=68.142.93.254&ignoreMismatch=on
https://www.ssllabs.com/ssltest/analyze.html?d=enawafeth.alarabiya.net&s=68.142.93.133&ignoreMismatch=on

Also urdu.alarabiya.net have some mixed content on page due to alarabiya.net ( https://imgur.com/YVZXO4d ), but that should be fixed by adding alarabiya.net to the list, right?
@ghost ghost changed the title Create alarabiya.net.xml Create-alarabiya.net.xml Nov 4, 2016
weylhasse added 5 commits November 4, 2016 21:38
Well, I don't know how to fix 
ERROR src/chrome/content/rules/alarabiya.net.xml: Fetch error: http://alarabiya.net/ => https://alarabiya.net/: (28, 'Connection timed out after 20000 milliseconds')
so will wait for some developers advice
(added farsi.alarabiya.net)
@jeremyn

jeremyn commented Nov 4, 2016

Copy link
Copy Markdown
Contributor

Thanks for your second ruleset. I hope you stay and become a regular contributor.

Your ruleset has some style and other problems. Please review the following links:

https://www.eff.org/https-everywhere/rulesets
https://github.com/EFForg/https-everywhere/blob/master/ruleset-style.md
https://github.com/EFForg/https-everywhere/blob/master/CONTRIBUTING.md

I'm sorry that our documentation is spread out like that.

Note that the host for a target does not include subdomains. So for example, you need to include a target for www.alarabiya.net if you want the ruleset to cover it. Also, there is an test automatically created for each target, so once you add a target for www.alarabiya.net, you don't need to add a test for it.

@ghost

ghost commented Nov 4, 2016 •

Copy link
Copy Markdown
Author

Thank you, @jeremyn . It seems alarabiya.net alone doesn't exist and that was causing errors.

@jeremyn

jeremyn commented Nov 4, 2016 •

Copy link
Copy Markdown
Contributor

Thanks. Please make the following changes. For the various "Mark as" issues, please mark them in a new comment at the top like you see in this ruleset example. Note that you should not include https:// in the comment.

Mark as Different HTTP/HTTPS content:

Mark as Invalid certificate:

Mark as Refused:

Mark as Time out:

Add target:

Also:

  • Change the ruleset name to Al Arabiya, without the dash, because this is how it spells itself on the English language page
  • In all cases where there is a list of domains, sort them in alphabetical order starting from the top level domain at the right reading left, moving ^ and www to the top of their group. For example:

Click to expand sort order example

example.com
www.example.com
a.example.com
www.a.example.com
b.a.example.com
b.example.com
example.net
www.example.net
a.example.net

@jeremyn jeremyn self-assigned this Nov 4, 2016
@jeremyn

jeremyn commented Nov 4, 2016

Copy link
Copy Markdown
Contributor

Also, for future reference, see here for suggestions on finding subdomains: #6681 (comment) , #7277 .

@ghost

ghost commented Nov 5, 2016

Copy link
Copy Markdown
Author

Should be fine now. Sorry about the mess.

@jeremyn

jeremyn commented Nov 5, 2016

Copy link
Copy Markdown
Contributor

No problem. alarabiya.net.xml looks fine now. Do you mind if I delete all of the commit messages from the squashed commit message?

Also, please remove digikala.com.xml and make a new pull request for it. Going forward, you may want to submit pull requests under branches other than master.

@ghost

ghost commented Nov 5, 2016 •

Copy link
Copy Markdown
Author

Do you mind if I delete all of the commit messages from the squashed commit message?

Sure. You may delete it.

Also, please remove digikala.com.xml and make a new pull request for it

I was going to do that, but made something wrong. It's okay now?

@jeremyn
jeremyn merged commit abe8d95 into EFForg:master Nov 5, 2016
@jeremyn

jeremyn commented Nov 5, 2016

Copy link
Copy Markdown
Contributor

Yes, it's fine now, thanks. Merged.

@jeremyn jeremyn removed their assignment Nov 5, 2016
@jeremyn jeremyn mentioned this pull request Nov 6, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant