Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

click.e.twitter.com (in Twitter marketing emails) inappropriately HTTPS-ified #7137

Closed

Description

@wjt

Twitter's marketing emails contain links to http://click.e.twitter.com/, which redirect to the actual target. For instance, an email about live streams of the US presidential debate has the following link: Watch live.

HTTPS Everywhere ships with a rule which matches this domain and https-ifies it, but the server serves a certificate only valid for a248.e.akamai.net, *.akamaized.net, *.akamaihd-staging.net, *.akamaihd.net, *.akamaized-staging.net.

(For what it's worth, click.e.twitter.com is a CNAME for click.virt.s7.exacttarget.com, a service run by Salesforce – which in turn is a CNAME for Akamai – rather than this being a tracking system run by Twitter themselves.)

Activity

  1. jeremyn commented on Sep 27, 2016

    @jeremyn
    Contributor

    Thanks for the report.

    Twitter.xml is the ruleset that matches click.e.twitter.com, specifically:

    <target host="*.twitter.com" />
    ...
        <rule from="^http:"
            to="https:" />

    There are at least two possible fixes:

    1. (Preferred but more work) Rewrite Twitter.xml to not use a wildcard target. Wildcards are discouraged by the style guide, in part because they can break subdomains like we're seeing here.
    2. (Less preferred, less work) Add click\.e to the exclusion tag with an appropriate test.
  2. wjt commented on Sep 28, 2016

    @wjt
    ContributorAuthor

    @jeremyn I guess there's no analytics mechanism by which one could see which domains are, in practice, being matched by the wildcard?

  3. jeremyn commented on Sep 28, 2016

    @jeremyn
    Contributor

    Unfortunately, no. #6681 (comment) describes some approaches. For this specific issue though, for option (1), it would be enough to use the test URLs already in the ruleset.

  4. J0WI commented on Oct 24, 2016

    @J0WI
    Contributor

    closed by #7416

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions