This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Repository navigation
Exclude click.e.twitter.com from the ruleset. - #7416
Merged
Merged
Conversation
J0WI
suggested changes
Oct 23, 2016
J0WI
left a comment
Contributor
There was a problem hiding this comment.
It seems that there are some obsolete test urls (see failing tests). Could you check and remove them?
| <test url="http://www.twitter.com/" /> | ||
|
|
||
| <exclusion pattern="^http://(?:status|app\.tweet|images\.tweet)\.twitter\.com/" /> | ||
| <exclusion pattern="^http://(?:status|app\.tweet|images\.tweet|click.e)\.twitter\.com/" /> |
Contributor
There was a problem hiding this comment.
Please avoid non-capturing groups.
Contributor
|
See also the discussion in duplicate issue #7137 . |
J0WI
approved these changes
Oct 24, 2016
Contributor
|
LGTM, Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7415.