Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Exclude click.e.twitter.com from the ruleset. - #7416

Merged
J0WI merged 3 commits into
EFForg:masterfrom
lfaraone:patch-1
Oct 24, 2016
Merged

J0WI merged 3 commits into
EFForg:masterfrom
lfaraone:patch-1

Conversation

@lfaraone

Copy link
Copy Markdown
Contributor

Fixes #7415.

@J0WI J0WI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that there are some obsolete test urls (see failing tests). Could you check and remove them?

Comment thread src/chrome/content/rules/Twitter.xml Outdated
<test url="http://www.twitter.com/" />

<exclusion pattern="^http://(?:status|app\.tweet|images\.tweet)\.twitter\.com/" />
<exclusion pattern="^http://(?:status|app\.tweet|images\.tweet|click.e)\.twitter\.com/" />

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please avoid non-capturing groups.

@jeremyn

jeremyn commented Oct 24, 2016

Copy link
Copy Markdown
Contributor

See also the discussion in duplicate issue #7137 .

@J0WI
J0WI merged commit 2b5d524 into EFForg:master Oct 24, 2016
@J0WI

J0WI commented Oct 24, 2016

Copy link
Copy Markdown
Contributor

LGTM, Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants