Skip to content

Adds --human-readable parameter to db size command - #124

Merged
schlessera merged 6 commits into
wp-cli:masterfrom
pmgarman:issue/108
Dec 17, 2018
Merged

schlessera merged 6 commits into
wp-cli:masterfrom
pmgarman:issue/108

Conversation

@pmgarman

@pmgarman pmgarman commented Dec 9, 2018 •

Copy link
Copy Markdown
Contributor

Solves #108

@swissspidy

Copy link
Copy Markdown
Member

WordPress core has a size_format() function. Can we perhaps add a similar helper function to WP-CLI, maybe as part of the Utils lib?

@schlessera schlessera left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the general approach. Let's add basic tests, then we're good for a merge.

Comment thread src/DB_Command.php Resolved
Comment thread src/DB_Command.php Resolved
Comment thread src/DB_Command.php Resolved
schlessera and others added 2 commits December 9, 2018 13:43
Co-Authored-By: pmgarman <patrick@garman.io>
Co-Authored-By: pmgarman <patrick@garman.io>
@schlessera

Copy link
Copy Markdown
Member

Tests currently failing because of #125

@pmgarman pmgarman changed the title WIP: Adds —human-readable parameter to db size command Adds —human-readable parameter to db size command Dec 10, 2018
@schlessera schlessera added the command:db-size Related to 'db size' command label Dec 12, 2018
@schlessera schlessera added this to the 2.0.1 milestone Dec 17, 2018
@schlessera
schlessera merged commit 2ab6bd0 into wp-cli:master Dec 17, 2018
@schlessera

Copy link
Copy Markdown
Member

Thanks for the PR, @pmgarman !

@schlessera schlessera changed the title Adds —human-readable parameter to db size command Adds --human-readable parameter to db size command Dec 17, 2018
danielbachhuber pushed a commit that referenced this pull request Nov 18, 2022
Adds `--human-readable` parameter to `db size` command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

command:db-size Related to 'db size' command

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants