Repository navigation
Fix --size_format argument definition. - #130
Merged
Merged
Conversation
It should be `--size_format=<format>` because it's never a flag. Also adds `--human-readable` to README docs.
danielbachhuber
added
command:db-size
These are also used to validate the passed value, which means they need to be bare.
swissspidy
approved these changes
Jan 24, 2019
Otherwise, it's included all of the time, which isn't expected.
Member
Author
|
Hm. Guess I should get these tests passing locally before I push my commits... |
Member
Author
|
@schlessera Any ideas why this might be failing in Travis? It passes for me locally. |
Member
|
@danielbachhuber It succeeded on my local system too, so I cleared the Travis caches and restarted the build, and it seems to have solved the issue so far. |
Member
Author
|
Interesting! Thanks :) |
danielbachhuber
pushed a commit
that referenced
this pull request
Nov 18, 2022
Fix `--size_format` argument definition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It should be
--size_format=<format>because it's never a flag. From #16.Also adds
--human-readableto README docs. From #124.