Skip to content

Tests for db export fail on Gutenberg HTML comments #125

New issue
New issue
Closed
Closed
Tests for db export fail on Gutenberg HTML comments#125
Labels
command:db-exportRelated to 'db export' commandgood-first-issueGood for newcomers
Milestone
2.0.1

Description

@schlessera
schlessera
opened on Dec 9, 2018

The tests for db export contain, amongst others, an export of the post_content of the default posts/pages. These need to be updated as they now contain HTML comments to denote the Gutenberg blocks they are using.

See https://travis-ci.org/wp-cli/db-command/jobs/465672443#L656

Activity

  1. schlessera
    added
    command:db-exportRelated to 'db export' command
    good-first-issueGood for newcomers
    on Dec 9, 2018

  2. schlessera commented on Dec 12, 2018

    @schlessera
    schlessera
    on Dec 12, 2018
    MemberAuthor

    The test uses --skip-comments to test argument passing and then tries to assert that no MySQL comment with -- is in the produced export. However, Gutenberg-style HTML comments (<!-- -->) also fit that check and make it fail.

  3. danielbachhuber
    closed this as completedin #127on Dec 12, 2018
  4. danielbachhuber
    added this to the 2.0.1 milestone on Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    command:db-exportRelated to 'db export' commandgood-first-issueGood for newcomers

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions