Repository navigation
DTMF-additional-support - add support for IN_BAND DTMF - #629
Conversation
|
See documentation PR as well versatica/jssip.net#5 |
|
It is based on this PR, yes? #601 |
|
Should be g2g now |
ibc
left a comment
There was a problem hiding this comment.
Some changes requested, but even when those are handled, I don't think this is ok. What about this line which is also called even when using in band DTMF?:
// Set timeout for the next tone.
setTimeout(_sendDTMF.bind(this), timeout);@jmillan what to do here?
| } | ||
| case JsSIP_C.DTMF_TRANSPORT.INFO: { |
There was a problem hiding this comment.
Blank line between case. BTW: does hit pass gulp lint or not? You did not answer before.
| } | |
| case JsSIP_C.DTMF_TRANSPORT.INFO: { | |
| } | |
| case JsSIP_C.DTMF_TRANSPORT.INFO: { |
There was a problem hiding this comment.
yes it does pass. I will add the blank line as requested
Isn't this just for handling if multiple tones are sent? What would the problem be? |
|
I think the terminology here is wrong (or confusing). For instance https://developer.mozilla.org/en-US/docs/Web/API/WebRTC_API/Using_DTMF refers to in-band as sending DTMF as an audio signal using G.711. RFC4733 tones, which are generated by RTCDTMFSender.insertDTMF, are referred to as out of band. SIP INFO messages are technically out-of-band as well. Better name, instead of IN_BAND, should be something like TELEPHONE_EVENT or RFC2833 or RFC4733. |
|
Since this PR is based off of #601 I believe |
|
Just a last minor request change and we are ready to merge. |
// Set timeout for the next tone.
setTimeout(_sendDTMF.bind(this), timeout);
It's OK, since we are sending a DTMF at a time in both cases. |
Co-authored-by: Iñaki Baz Castillo <ibc@aliax.net>
@ibc done |
|
Thanks, shipped in JsSIP 3.4.5. |
based off of comments for #496 and #601