Repository navigation
Conversation
Krivega
reviewed
Nov 12, 2019
ibc
reviewed
Nov 12, 2019
Author
ibc
requested changes
Nov 14, 2019
jmillan
reviewed
Nov 15, 2019
ibc
requested changes
Nov 18, 2019
ibc
left a comment
Member
There was a problem hiding this comment.
May you also send a PR adding this to the doc? https://github.com/versatica/jssip.net/blob/master/content/documentation/3.3.x/api/session.html#L211
| */ | ||
| const holdMediaTypes = [ 'audio', 'video' ]; | ||
|
|
||
| const RFC2833 = 'RFC2833'; |
Member
There was a problem hiding this comment.
Do we really need this const? I think it provides no much value and we can get rid of it.
Member
| const sender = this._getDTMFRTPSender(); | ||
|
|
||
| if (sender) | ||
| { |
Member
There was a problem hiding this comment.
Can we get rid of those unneeded brackets? BTW: have you tested gulp lint?
Contributor
|
@ibc should probably close this one |
Member
|
Done in 3.4.5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently SIPJS supports RFC 2833 for DTMF (onsip/SIP.js#511)
I think will be nice that JSIP supports it too 😄
Based on the comments that I found #496 the
sendDtmfcould take an extra option to define the DTMF type instead of UA level.