Skip to content

Add support for rfc 2833 - #601

Closed
chukitow wants to merge 4 commits into
versatica:masterfrom
chukitow:feature/Add-support-for-rfc-2833
Closed

chukitow wants to merge 4 commits into
versatica:masterfrom
chukitow:feature/Add-support-for-rfc-2833

Conversation

@chukitow

Copy link
Copy Markdown

Currently SIPJS supports RFC 2833 for DTMF (onsip/SIP.js#511)
I think will be nice that JSIP supports it too 😄

Based on the comments that I found #496 the sendDtmf
could take an extra option to define the DTMF type instead of UA level.

Comment thread lib/RTCSession.js Resolved
Comment thread lib/RTCSession.js Resolved
@chukitow

Copy link
Copy Markdown
Author

I updated the PR based on your comments @ibc @jmillan

Comment thread lib/RTCSession.js Resolved
@chukitow
chukitow requested a review from ibc November 14, 2019 16:48
Comment thread lib/RTCSession.js Resolved

@ibc ibc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread lib/RTCSession.js
*/
const holdMediaTypes = [ 'audio', 'video' ];

const RFC2833 = 'RFC2833';

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need this const? I think it provides no much value and we can get rid of it.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ibc I agree with you. There is no need for this const.

To make it more clear to @chukitow, do you want to share your suggestion for removing this constant?

Comment thread lib/RTCSession.js
const sender = this._getDTMFRTPSender();

if (sender)
{

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get rid of those unneeded brackets? BTW: have you tested gulp lint?

@acharlop

Copy link
Copy Markdown
Contributor

@ibc should probably close this one

@ibc

ibc commented May 13, 2020

Copy link
Copy Markdown
Member

Done in 3.4.5

@ibc ibc closed this May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants