When in JsSIP 3.4.5 used: session.sendDTMF(tone, {transportType: 'RFC2833'}); throws exception: Uncaught TypeError: invalid transportType: RFC2833 When used valid value of transportType I think that RTCSession.js piece of code: if ( transportType !== JsSIP_C.DTMF_TRANSPORT.INFO || transportType !== JsSIP_C.DTMF_TRANSPORT.RFC2833 ) { throw new TypeError(`invalid transportType: ${transportType}`); } Should be changed to: if ( transportType !== JsSIP_C.DTMF_TRANSPORT.INFO **&&** transportType !== JsSIP_C.DTMF_TRANSPORT.RFC2833 ) { throw new TypeError(`invalid transportType: ${transportType}`); } ( || should be changed to &&) Thanks.
Activity
ibc commentedon May 19, 2020
Good catch. Fixing it.
ibc commentedon May 19, 2020
Released in JsSIP 3.4.6, thanks
Fix versatica#630
Fix versatica#630