Skip to content

problem with sendDTMF #630

Closed
Closed

Description

@ikq

When in JsSIP 3.4.5 used:
session.sendDTMF(tone, {transportType: 'RFC2833'});

throws exception:
Uncaught TypeError: invalid transportType: RFC2833

When used valid value of transportType

I think that RTCSession.js piece of code:

if (
transportType !== JsSIP_C.DTMF_TRANSPORT.INFO ||
transportType !== JsSIP_C.DTMF_TRANSPORT.RFC2833
)
{
throw new TypeError(invalid transportType: ${transportType});
}

Should be changed to:

if (
transportType !== JsSIP_C.DTMF_TRANSPORT.INFO &&
transportType !== JsSIP_C.DTMF_TRANSPORT.RFC2833
)
{
throw new TypeError(invalid transportType: ${transportType});
}

( || should be changed to &&)
Thanks.

Activity

  1. ibc commented on May 19, 2020

    @ibc
    Member

    Good catch. Fixing it.

  2. ibc commented on May 19, 2020

    @ibc
    Member

    Released in JsSIP 3.4.6, thanks

  3. added a commit that references this issue on Aug 21, 2020
    2632e49
  4. added a commit that references this issue on Aug 30, 2024
    aba4739
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions