Skip to content

app/prj.conf: disable PICOLIBC with CONFIG_MINIMAL_LIBC=y - #8255

Merged
kv2019i merged 1 commit into
thesofproject:mainfrom
marc-hb:disable-picolibc
Sep 25, 2023
Merged

kv2019i merged 1 commit into
thesofproject:mainfrom
marc-hb:disable-picolibc

Conversation

@marc-hb

@marc-hb marc-hb commented Sep 23, 2023

Copy link
Copy Markdown
Collaborator

Starting from Zephyr commit f0daf904bb02, CONFIG_PICOLIBC is on by default.

PICOLIBC does not seem compatible with sparse yet: zephyrproject-rtos/zephyr#63003

Even if it were compatible with sparse, it seems like a pretty big change that we should not immediately and blindly accept.

Starting from Zephyr commit f0daf904bb02, CONFIG_PICOLIBC is on by
default.

PICOLIBC does not seem compatible with sparse yet:
zephyrproject-rtos/zephyr#63003

Even if it were compatible with sparse, it seems like a pretty big
change that we should not immediately and blindly accept.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
@marc-hb

marc-hb commented Sep 23, 2023

Copy link
Copy Markdown
Collaborator Author

The fix for the unrelated build-windows failures is in:

@marc-hb
marc-hb marked this pull request as ready for review September 23, 2023 09:09
@kv2019i

kv2019i commented Sep 25, 2023

Copy link
Copy Markdown
Collaborator

Excellent debug @marc-hb on the sparse problem. On one hand, now would be a good time to change to picolibc (as we are very early in 2.8 cycle), but agreed, we need to solve the sparse issue first (and not block other Zephyr updated due to this).

@kv2019i

kv2019i commented Sep 25, 2023

Copy link
Copy Markdown
Collaborator

@wszypelt ok to merge despite failures? this is gating Zephyr updates now and this PR alone does not have any change to build -- it explicitly sets an option that newer Zephyr versions would change to something else by default.

@wszypelt

Copy link
Copy Markdown

@kv2019i We had a problem with the network on the machines, the LAB team has already fixed it, correct results should be available within an hour

@tmleman

tmleman commented Sep 25, 2023

Copy link
Copy Markdown
Contributor

@kv2019i I think we can merge it

@kv2019i
kv2019i merged commit 2a9473a into thesofproject:main Sep 25, 2023
@marc-hb
marc-hb deleted the disable-picolibc branch September 26, 2023 18:05
@marc-hb

marc-hb commented Sep 26, 2023

Copy link
Copy Markdown
Collaborator Author

Actually we can make this workaround more sparse-specific, not sure why I didn't think about that earlier. Please review small follow-up:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants