Repository navigation
.github/sparse-zephyr: add -DCONFIG_MINIMAL_LIBC to avoid picolibc - #8267
Merged
Merged
Conversation
Add a sparse-specific workaround for the incompatibility with picolibc (the new Zephyr default) zephyrproject-rtos/zephyr#63003 Also fix comment in commit 2a9473a ("app/prj.conf: disable PICOLIBC with CONFIG_MINIMAL_LIBC=y"): we don't need to disable PICOLIBC _everywhere_; we only need to disable it when using sparse. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb
marked this pull request as ready for review
September 26, 2023 18:04
marc-hb
requested review from
cujomalainey,
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
September 26, 2023 18:04
lgirdwood
approved these changes
Sep 27, 2023
tmleman
approved these changes
Sep 27, 2023
lyakh
approved these changes
Sep 27, 2023
lyakh
left a comment
lyakh
left a comment
Collaborator
There was a problem hiding this comment.
would a sparse overlay be possible and desirable?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a sparse-specific workaround for the incompatibility with picolibc (the new Zephyr default)
Also fix comment in commit 2a9473a ("app/prj.conf: disable PICOLIBC with CONFIG_MINIMAL_LIBC=y"): we don't need to disable PICOLIBC everywhere; we only need to disable it when using sparse.