Skip to content

[SKIP SOF-TEST] .github: build-windows: choco install ninja - #8254

Merged
kv2019i merged 1 commit into
thesofproject:mainfrom
marc-hb:choco-install-ninja
Sep 25, 2023
Merged

kv2019i merged 1 commit into
thesofproject:mainfrom
marc-hb:choco-install-ninja

Conversation

@marc-hb

@marc-hb marc-hb commented Sep 22, 2023

Copy link
Copy Markdown
Collaborator

Ninja seems to have just mysteriously disappeared from https://github.com/actions/runner-images/blob/win22/20230918.1/images/win/Windows2022-Readme.md See #8250 for more details.

Let's try to install it explicitly.

Ninja seems to have just mysteriously disappeared from
https://github.com/actions/runner-images/blob/win22/20230918.1/images/win/Windows2022-Readme.md
See thesofproject#8250 for more details.

Let's try to install it explicitly.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
@marc-hb
marc-hb marked this pull request as ready for review September 22, 2023 19:17
@marc-hb marc-hb added bug Something isn't working as expected P1 Blocker bugs or important features labels Sep 22, 2023

@fredoh9 fredoh9 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@kv2019i
kv2019i merged commit 8eedfe4 into thesofproject:main Sep 25, 2023
@marc-hb
marc-hb deleted the choco-install-ninja branch October 20, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working as expected P1 Blocker bugs or important features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants