Repository navigation
Conversation
Commit 9cc6454 ("module_adapter: Extend the module interface for endpoint devices") added use of struct comp_dev and struct timestamp_data to module_interface.h without required include header and/or forward declarations. This leads to compiler warnings. Address the issue by adding forward declarations for these structs as implementation details are not needed in this header. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i
requested review from
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
July 14, 2023 10:20
Merged
Merged
jsarha
approved these changes
Jul 14, 2023
jsarha
left a comment
jsarha
left a comment
Contributor
There was a problem hiding this comment.
Fixes the building issue we have seen lately.
Collaborator
Author
|
Duplicate of #7945 (which was merged), so closing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 9cc6454 ("module_adapter: Extend the module interface for endpoint devices") added use of struct comp_dev and struct timestamp_data to module_interface.h without required include header and/or forward declarations. This leads to compiler warnings. Address the issue by adding forward declarations for these structs as implementation details are not needed in this header.