Repository navigation
Fixup waves adapter - #7942
Merged
Merged
Fixup waves adapter#7942
Conversation
Now that waves headers are published they should not be trying to include local headers or modifying the global scope. Fixup headers so they include like the rest of public headers. Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>
cujomalainey
requested review from
dbaluta,
jxstelter,
lbetlej,
lgirdwood,
mmaka1,
plbossart and
ranj063
as code owners
July 13, 2023 18:09
Since 3P code can't be compiled without the library (for now) we rely on reviews for API conversions which unfortunately has proven to not be perfect. Fixup the accessors for the waves module. Fixes: e57883f ("buffer: use an accessor to read struct audio_stream::channels") Fixes: f8e4d69 ("buffer: use an accessor to read struct audio_stream::rate") Fixes: 017b8eb ("buffer: use an accessor to read struct audio_stream::frame_fmt") Fixes: 90828e2 ("buffer: external modules use API to access buffer_fmt") Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>
cujomalainey
changed the title
btian1
approved these changes
Jul 14, 2023
lyakh
approved these changes
Jul 14, 2023
|
|
||
| /* resampling not supported */ | ||
| if (src_fmt->rate != audio_stream_get_rate(snk_fmt)) { | ||
| if (audio_stream_get_rate(src_fmt) != audio_stream_get_rate(snk_fmt)) { |
Collaborator
There was a problem hiding this comment.
oh, yeah, that's the punishment for being too inventive with names, we couldn't possibly have guessed to grep for src_fmt as a buffer stream name ;-)
|
|
||
| /* different interleaving is not supported */ | ||
| if (source_c->buffer_fmt != sink_c->buffer_fmt) { | ||
| if (audio_stream_get_buffer_fmt(src_fmt) != audio_stream_get_buffer_fmt(snk_fmt)) { |
Collaborator
There was a problem hiding this comment.
ok, these ones should've been caught, but looks like they were wrong too
kv2019i
approved these changes
Jul 14, 2023
kv2019i
left a comment
kv2019i
left a comment
Collaborator
There was a problem hiding this comment.
wow, waves.c had a lot of missed places
Collaborator
|
Build failures are caused by a regression (to be fixed by #7949 ), rest looks good as expected as this is only touching code not covered by CI. |
Contributor
Author
Working to fix that so this is covered by CI going forward :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixups for Waves adapter