Repository navigation
Fix intelligo adapter - #7944
Conversation
The headers are under the main include directory Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>
Needed for the config type Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>
btian1
left a comment
btian1
left a comment
There was a problem hiding this comment.
Are we try to re-integrate this part of code into SOF?
| cd->sink_rate = audio_stream_get_rate(&sink_c->stream); | ||
|
|
||
| if (audio_stream_get_channels(source_c->stream) != | ||
| if (audio_stream_get_channels(&source_c->stream) != |
There was a problem hiding this comment.
interesting, this part of code should not be compiled with current build system, compiler will report error with this cse.
There was a problem hiding this comment.
Yes, it's because it's not test in CI currently, trying to fix that :)
The code depends on a 3P library that hasn't been integrated past the CAVS2.5 branch. I'm working on adding stub libraries so we can at least build test and fuzz adapter code. These fixes are my findings from this work. |
kv2019i
left a comment
kv2019i
left a comment
There was a problem hiding this comment.
Thanks @cujomalainey ! A stub that would allow at least a compile test in CI would be nice to catch these indeed.
|
Lot of failing cases. We have a mismatch with upstream Zephyr main (not related to this PR), and we also have a regression in SOF main causing compiler warnings (again not related to this PR -> #7949 ). So good to go for this PR. |
API modification breakages