Skip to content

Fix intelligo adapter #7944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kv2019i merged 4 commits into from
Jul 14, 2023
Merged

Fix intelligo adapter #7944

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9a5739b
audio: igo: Fix buffer access arg
cujomalainey Jul 13, 2023
935aea3
audio: igo: fix create arg attributes
cujomalainey Jul 13, 2023
41a6a80
audio: igo: remove unneeded header path include
cujomalainey Jul 13, 2023
ff77a44
audio: igo: add missing header include
cujomalainey Jul 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/audio/igo_nr/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
# SPDX-License-Identifier: BSD-3-Clause

target_include_directories(sof_public_headers INTERFACE ${CMAKE_CURRENT_SOURCE_DIR})

add_local_sources(sof igo_nr.c)
sof_add_static_library(IGOChrome ${CMAKE_CURRENT_LIST_DIR}/libigonr.a)
6 changes: 3 additions & 3 deletions src/audio/igo_nr/igo_nr.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,9 +276,9 @@ static inline int32_t set_capture_func(struct comp_dev *dev)
}

static struct comp_dev *igo_nr_new(const struct comp_driver *drv,
struct comp_ipc_config *config, void *spec)
const struct comp_ipc_config *config, const void *spec)
{
struct ipc_config_process *ipc_igo_nr = spec;
const struct ipc_config_process *ipc_igo_nr = spec;
struct comp_dev *dev = NULL;
struct comp_data *cd = NULL;
size_t bs = ipc_igo_nr->size;
Expand Down Expand Up @@ -402,7 +402,7 @@ static int32_t igo_nr_params(struct comp_dev *dev,
cd->source_rate = audio_stream_get_rate(&source_c->stream);
cd->sink_rate = audio_stream_get_rate(&sink_c->stream);

if (audio_stream_get_channels(source_c->stream) !=
if (audio_stream_get_channels(&source_c->stream) !=

@btian1 btian1 Jul 14, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting, this part of code should not be compiled with current build system, compiler will report error with this cse.

@cujomalainey cujomalainey Jul 14, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's because it's not test in CI currently, trying to fix that :)

audio_stream_get_channels(&sink_c->stream)) {
comp_err(dev, "igo_nr_params(), mismatch source/sink stream channels");
cd->invalid_param = true;
Expand Down
1 change: 1 addition & 0 deletions src/include/sof/audio/igo_nr/igo_nr_comp.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
#include <sof/platform.h>
#include <sof/audio/audio_stream.h>
#include <sof/audio/igo_nr/igo_lib.h>
#include <user/igo_nr.h>

#define IGO_FRAME_SIZE (768)
#define IGO_NR_IN_BUF_LENGTH (IGO_FRAME_SIZE)
Expand Down