Skip to content

.github/build-tools: build again verbose and single threaded after a failure - #5640

Merged
lgirdwood merged 2 commits into
thesofproject:mainfrom
marc-hb:single-thread-build
Apr 5, 2022
Merged

lgirdwood merged 2 commits into
thesofproject:mainfrom
marc-hb:single-thread-build

Conversation

@marc-hb

@marc-hb marc-hb commented Apr 2, 2022

Copy link
Copy Markdown
Collaborator

2 commits, see commit messages.

Building in parallel is much faster but it makes logs unreadable and
build failures impossible to understand.

To show errors, try to build again with a single thread on failure.

marc-hb added 2 commits April 1, 2022 23:58
Building in parallel is much faster but it makes logs unreadable and
build failures impossible to understand. This is especially true when
building with recent ALSA that produces of deprecation warnings, see
examples below. For test topologies the problem is even worse: its
XARGS parallel build provides no log at all.

To find what actually fails, it is required to fall back on a single
threaded and verbose build and this is achieved with the variables
USE_XARGS, NO_PROCESSORS and VERBOSE. Pass these through docker-run.sh
and CMake.

Examples from thesofproject#5608
https://github.com/thesofproject/sof/runs/5717553555?check_suite_focus=true
https://sof-ci.01.org/sofpr/PR5608/build12556/build/tools.txt

ALSA pcm.c:1523:(parse_hw_config) deprecated fsync value 'codec_slave',...
ALSA pcm.c:1471:(parse_hw_config) deprecated bclk value 'codec_slave',...
ALSA pcm.c:1523:(parse_hw_config) deprecated fsync value 'codec_slave',...
ALSA pcm.c:1471:(parse_hw_config) deprecated bclk value 'codec_slave',...
ALSA pcm.c:1523:(parse_hw_config) deprecated fsync value 'codec_slave',...

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Building in parallel is much faster but it makes logs unreadable and
build failures impossible to understand. This is especially true when
building with recent ALSA that produces of deprecation warnings.

To show what actually fails, try to build again with a single thread.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
@marc-hb

marc-hb commented Apr 2, 2022 •

Copy link
Copy Markdown
Collaborator Author

Test results are in throw-way PR #5639 where this was combined with build failures for demonstration purposes.

@marc-hb
marc-hb marked this pull request as ready for review April 2, 2022 00:15
@marc-hb marc-hb mentioned this pull request Apr 2, 2022
@marc-hb

marc-hb commented Apr 2, 2022

Copy link
Copy Markdown
Collaborator Author

ICL is broken as often @kkarask in https://sof-ci.01.org/sof-pr-viewer/#/build/PR5640/build8993943. Maybe we should stop testing ICL?

The two failures in https://sof-ci.01.org/sofpr/PR5640/build12608/devicetest/ are unrelated #5352

@lgirdwood

Copy link
Copy Markdown
Member

ICL is broken as often @kkarask in https://sof-ci.01.org/sof-pr-viewer/#/build/PR5640/build8993943. Maybe we should stop testing ICL?

This one is just is usually the DUT needing a reboot.

@kkarask

kkarask commented Apr 4, 2022

Copy link
Copy Markdown

We struggle with several issues on CI platforms now (ICL, TGL, JSL). It could take a while to solve all problems.

@wszypelt

wszypelt commented Apr 4, 2022

Copy link
Copy Markdown

@marc-hb @lgirdwood
The problem is on internal service, the issue has been reported, we are waiting for the task to be completed. Unfortunately, disconnecting the machine with the error will not solve the problem, because at this point it will appear on the next machine.

Comment thread .github/workflows/installer.yml
@lgirdwood
lgirdwood merged commit 791efe2 into thesofproject:main Apr 5, 2022
@marc-hb
marc-hb deleted the single-thread-build branch April 8, 2022 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants