Repository navigation
Stable v1.9 refine - #5608
Merged
lgirdwood merged 11 commits intoMar 31, 2022
Merged
Stable v1.9 refine#5608
Conversation
This reverts commit 5e89b58. Signed-off-by: Libin Yang <libin.yang@intel.com>
…& NOAMP support" This reverts commit f892b31. Signed-off-by: Libin Yang <libin.yang@intel.com>
…description" This reverts commit ee3631a. Signed-off-by: Libin Yang <libin.yang@intel.com>
…TION" This reverts commit 3904756. Signed-off-by: Libin Yang <libin.yang@intel.com>
…arts" This reverts commit 748b3ca. Signed-off-by: Libin Yang <libin.yang@intel.com>
…rmat" This reverts commit 93bf384. Signed-off-by: Libin Yang <libin.yang@intel.com>
This reverts commit 22b57a1. Signed-off-by: Libin Yang <libin.yang@intel.com>
NO_AGGREGATION is never used now. Let's remove it. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Signed-off-by: Libin Yang <libin.yang@intel.com>
The links are dynamically assigned. The descriptions should be changed correspondingly. Signed-off-by: Libin Yang <libin.yang@intel.com>
…support add sof-icl-rt711-rt1308-rt715-hdmi NO_LOCAL_MIC & NOAMP support Signed-off-by: Libin Yang <libin.yang@intel.com>
Add sof-adl-rt711-l2-rt1316-l01 support. This tplg doesn't include any local MICs. Signed-off-by: Libin Yang <libin.yang@intel.com>
libinyang
requested review from
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
March 28, 2022 09:18
lgirdwood
approved these changes
Mar 28, 2022
lgirdwood
left a comment
lgirdwood
left a comment
Member
There was a problem hiding this comment.
@libinyang pls let me know when this backport PR is validated.
Contributor
Author
|
@lgirdwood As the CI system fails build the old tplg, I built the tplg and trigger the CI system manually. The test passes. |
Collaborator
|
Topologies build fix submitted in #5632 |
marc-hb
added a commit
to marc-hb/sof
that referenced
this pull request
Apr 1, 2022
Building in parallel is much faster but it makes logs unreadable and build failures impossible to understand. This is especially true when building with recent ALSA that produces of deprecation warnings, see examples below. For test topologies the problem is even worse: its XARGS parallel build provides no log at all. To find what actually fails, it is required to fall back on a single threaded and verbose build and this is achieved with the variables USE_XARGS, NO_PROCESSORS and VERBOSE. Pass these through docker-run.sh and CMake. Examples from thesofproject#5608 https://github.com/thesofproject/sof/runs/5717553555?check_suite_focus=true https://sof-ci.01.org/sofpr/PR5608/build12556/build/tools.txt ALSA pcm.c:1523:(parse_hw_config) deprecated fsync value 'codec_slave',... ALSA pcm.c:1471:(parse_hw_config) deprecated bclk value 'codec_slave',... ALSA pcm.c:1523:(parse_hw_config) deprecated fsync value 'codec_slave',... ALSA pcm.c:1471:(parse_hw_config) deprecated bclk value 'codec_slave',... ALSA pcm.c:1523:(parse_hw_config) deprecated fsync value 'codec_slave',... Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb
added a commit
to marc-hb/sof
that referenced
this pull request
Apr 1, 2022
Building in parallel is much faster but it makes logs unreadable and build failures impossible to understand. This is especially true when building with recent ALSA that produces of deprecation warnings, see examples below. For test topologies the problem is even worse: its XARGS parallel build provides no log at all. To find what actually fails, it is required to fall back on a single threaded and verbose build and this is achieved with the variables USE_XARGS, NO_PROCESSORS and VERBOSE. Pass these through docker-run.sh and CMake. Examples from thesofproject#5608 https://github.com/thesofproject/sof/runs/5717553555?check_suite_focus=true https://sof-ci.01.org/sofpr/PR5608/build12556/build/tools.txt ALSA pcm.c:1523:(parse_hw_config) deprecated fsync value 'codec_slave',... ALSA pcm.c:1471:(parse_hw_config) deprecated bclk value 'codec_slave',... ALSA pcm.c:1523:(parse_hw_config) deprecated fsync value 'codec_slave',... ALSA pcm.c:1471:(parse_hw_config) deprecated bclk value 'codec_slave',... ALSA pcm.c:1523:(parse_hw_config) deprecated fsync value 'codec_slave',... Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Collaborator
|
It's impossible to find what exactly fails to build in https://github.com/thesofproject/sof/runs/5717552879 and others. Fixed by small but impactful change #5640, please review. |
lgirdwood
pushed a commit
that referenced
this pull request
Apr 5, 2022
Building in parallel is much faster but it makes logs unreadable and build failures impossible to understand. This is especially true when building with recent ALSA that produces of deprecation warnings, see examples below. For test topologies the problem is even worse: its XARGS parallel build provides no log at all. To find what actually fails, it is required to fall back on a single threaded and verbose build and this is achieved with the variables USE_XARGS, NO_PROCESSORS and VERBOSE. Pass these through docker-run.sh and CMake. Examples from #5608 https://github.com/thesofproject/sof/runs/5717553555?check_suite_focus=true https://sof-ci.01.org/sofpr/PR5608/build12556/build/tools.txt ALSA pcm.c:1523:(parse_hw_config) deprecated fsync value 'codec_slave',... ALSA pcm.c:1471:(parse_hw_config) deprecated bclk value 'codec_slave',... ALSA pcm.c:1523:(parse_hw_config) deprecated fsync value 'codec_slave',... ALSA pcm.c:1471:(parse_hw_config) deprecated bclk value 'codec_slave',... ALSA pcm.c:1523:(parse_hw_config) deprecated fsync value 'codec_slave',... Signed-off-by: Marc Herbert <marc.herbert@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the support for NO MIC platforms.
The previous PR missed some patches when backing port, which caused compile failure.
Revert the patches and resubmit them.
This PR passes the compile and the BE ID matches expectation.