Skip to content

TEST IGNORE BREAK topologies with some whitespace - #5639

Closed
marc-hb wants to merge 3 commits into
thesofproject:mainfrom
marc-hb:topo-breakage
Closed

TEST IGNORE BREAK topologies with some whitespace#5639
marc-hb wants to merge 3 commits into
thesofproject:mainfrom
marc-hb:topo-breakage

Conversation

@marc-hb

@marc-hb marc-hb commented Apr 1, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

marc-hb added 3 commits April 1, 2022 23:12
@marc-hb
BREAK topologies with some whitespace
aff5ee7 
This breaks newer ALSA versions
@marc-hb
topologies: docker --env USE_XARGS, NO_PROCESSORS and VERBOSE
1936acb 
Building in parallel is much faster but it makes logs unreadable and
build failures impossible to understand. This is especially true when
building with recent ALSA that produces of deprecation warnings, see
examples below. For test topologies the problem is even worse: its
XARGS parallel build provides no log at all.

To find what actually fails, it is required to fall back on a single
threaded and verbose build and this is achieved with the variables
USE_XARGS, NO_PROCESSORS and VERBOSE. Pass these through docker-run.sh
and CMake.

Examples from thesofproject#5608
https://github.com/thesofproject/sof/runs/5717553555?check_suite_focus=true
https://sof-ci.01.org/sofpr/PR5608/build12556/build/tools.txt

ALSA pcm.c:1523:(parse_hw_config) deprecated fsync value 'codec_slave',...
ALSA pcm.c:1471:(parse_hw_config) deprecated bclk value 'codec_slave',...
ALSA pcm.c:1523:(parse_hw_config) deprecated fsync value 'codec_slave',...
ALSA pcm.c:1471:(parse_hw_config) deprecated bclk value 'codec_slave',...
ALSA pcm.c:1523:(parse_hw_config) deprecated fsync value 'codec_slave',...

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
@marc-hb
.github: build again single-threaded and verbose on failure
19442a4 
Building in parallel is much faster but it makes logs unreadable and
build failures impossible to understand. This is especially true when
building with recent ALSA that produces of deprecation warnings.

To show what actually fails, try to build again with a single thread.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
@marc-hb

marc-hb commented Apr 1, 2022

Copy link
Copy Markdown
Collaborator Author

ICL is failing again in https://sof-ci.01.org/sof-pr-viewer/#/build/PR5639/build8993664 @kkarask ... really unreliable.

@marc-hb

marc-hb commented Apr 2, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

@marc-hb marc-hb mentioned this pull request Apr 2, 2022
Merged
@marc-hb

marc-hb commented Apr 6, 2022

Copy link
Copy Markdown
Collaborator Author

https://sof-ci.01.org/sofpr/PR5639/build12607/devicetest/ shows a very misleading "not available (hardware)"

@sys-pt1s

sys-pt1s commented Apr 15, 2022

Copy link
Copy Markdown

Can one of the admins verify this patch?

@marc-hb marc-hb closed this Apr 15, 2022
@marc-hb
marc-hb deleted the topo-breakage branch April 15, 2022 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbaluta dbaluta Awaiting requested review from dbaluta dbaluta will be requested when the pull request is marked ready for review dbaluta is a code owner
@lgirdwood lgirdwood Awaiting requested review from lgirdwood lgirdwood will be requested when the pull request is marked ready for review lgirdwood is a code owner
@ranj063 ranj063 Awaiting requested review from ranj063 ranj063 will be requested when the pull request is marked ready for review ranj063 is a code owner
@plbossart plbossart Awaiting requested review from plbossart plbossart will be requested when the pull request is marked ready for review plbossart is a code owner
@mmaka1 mmaka1 Awaiting requested review from mmaka1 mmaka1 will be requested when the pull request is marked ready for review mmaka1 is a code owner
@lbetlej lbetlej Awaiting requested review from lbetlej lbetlej will be requested when the pull request is marked ready for review lbetlej is a code owner
@kv2019i kv2019i Awaiting requested review from kv2019i kv2019i will be requested when the pull request is marked ready for review kv2019i is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marc-hb @sys-pt1s