Add panic info into panic dump and fix some issues to make code build by xiulipan · Pull Request #423 · thesofproject/sof

xiulipan · 2018-09-26T13:22:17Z

Store the PS register and dump the oldps
Fix some header issues when adding some header into panic.h
Add panic info into panic dump.

The register PS will always be changed due to the IRQ disable. Store the old PS and dump that value. Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>

Include dma.h in alloc.h will cause some error, remove the unneeded dma.h and add some need header after remove it. Also move some helper function into alloc.c to avoid some warnings. Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>

clk will use timer function, add timer.h include for it. Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>

Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>

platform_panic is defined in platform/platform.h empty define in sof/platform.h is no use Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>

Use sof_ipc_panic_info to store panic info inclueded filename and line number. Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>

Add filename and line number of the panic call into the panic info. Then dump this info to host. Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>

xiulipan · 2018-09-26T13:29:49Z

@lgirdwood
Need #422 to fix host build failed by #411

lgirdwood · 2018-09-26T14:35:54Z

 void free_heap(int zone);

-/* flush block map from cache to sram */
-static inline void flush_block_map(struct block_map *map)


What error, please include error this fixes in commit message.

That will be very long list.
Since I add
#include <sof/alloc.h>
in panic.h
I just fixed the related header to have these patches.
I will list the errors later.

@xiulipan I dont need a list of errors, but just something similar to "fixes build error for target X caused by missing header Y" will do.

@lgirdwood
So I need to modify the comments?

xiulipan · 2018-09-27T04:21:50Z

 #include <string.h>
 #include <stdint.h>
 #include <sof/bit.h>
-#include <sof/dma.h>


alloc: fix some build issues in alloc

In file included from ../../src/include/sof/alloc.h:38,
from ../../src/include/sof/panic.h:35,
from /home/pxl/work/sof/sof/src/arch/xtensa/include/arch/wait.h:33,
from ../../src/include/sof/wait.h:38,
from ../../src/include/sof/schedule.h:41,
from /home/pxl/work/sof/sof/src/arch/xtensa/include/arch/task.h:41,
from ../../src/include/sof/task.h:34,
from init.c:36:
../../src/include/sof/dma.h:291:2: error: unknown type name 'completion_t'
completion_t complete;

xiulipan · 2018-09-27T04:24:35Z

 #include <stdint.h>
 #include <sof/bit.h>
-#include <sof/dma.h>
+#include <sof/platform.h>


../../src/include/sof/alloc.h:89:31: error: 'PLATFORM_DCACHE_ALIGN' undeclared here (not in a function); did you mean 'PLATFORM_HEAP_RUNTIME'?
} attribute ((aligned(PLATFORM_DCACHE_ALIGN)));
^~~~~~~~~~~~~~~~~~~~~
PLATFORM_HEAP_RUNTIME

PLATFORM_DCACHE_ALIGN is defined in sof/platform.h

xiulipan · 2018-09-27T04:24:56Z

-#include <sof/dma.h>
+#include <sof/platform.h>
 #include <platform/memory.h>
+#include <arch/spinlock.h>


../../src/include/sof/alloc.h:113:2: error: unknown type name 'spinlock_t'
spinlock_t lock; /* all allocs and frees are atomic */
spinlock_t is defined in arch/spinlock.h

xiulipan · 2018-09-27T04:26:06Z

-/* flush block map from cache to sram */
-static inline void flush_block_map(struct block_map *map)
-{
-	dcache_writeback_invalidate_region(map->block,


../../src/include/sof/alloc.h: In function 'flush_block_map':
../../src/include/sof/alloc.h:144:2: error: implicit declaration of function 'dcache_writeback_invalidate_region' [-Werror=implicit-function-declaration]
dcache_writeback_invalidate_region(map->block,

This function is only a helper function for alloc.c
No need to be in header.

xiulipan · 2018-09-27T04:28:12Z

 int platform_init(struct sof *sof);

-/**
- * \brief Called by the panic handler.


../../src/include/sof/platform.h:76:20: error: 'platform_panic' declared 'static' but never defined [-Werror=unused-function]
static inline void platform_panic(uint32_t p);

platform_panic is defined in platform/platform.h
Redeclared here

xiulipan · 2018-09-27T04:29:25Z


 #include <sof/lock.h>
 #include <sof/trace.h>
+#include <sof/wait.h>


/home/pxl/work/sof/sof/src/platform/intel/include/platform/cavs/pm_runtime.h:57:3: error: implicit declaration of function 'wait_delay'; did you mean 'init_heap'? [-Werror=implicit-function-declaration]
wait_delay(PLATFORM_FORCE_L1_EXIT_TIME);

wait_delay is defined in sof/wait.h

xiulipan · 2018-09-27T04:30:20Z

 #include <platform/timer.h>
 #include <platform/platform.h>
 #include <platform/clk.h>
+#include <sof/drivers/timer.h>


agent.c:58:18: error: implicit declaration of function 'platform_timer_get'; did you mean 'platform_init'? [-Werror=implicit-function-declaration]
sa->last_idle = platform_timer_get(platform_timer);

platform_timer_get is defined in sof/drivers/timer.h

xiulipan · 2018-09-27T04:34:45Z

@lrgirdwo
Did not know why modify one include file will cause domino effect error in building.
If that means we have some wrong include or over include file in our headers?

lgirdwood · 2018-09-27T07:25:41Z

@xiulipan modifying one include that is included by others or included in a different order in other files may have some knock on effects if there are missing declaration or dependencies. It seem you have fixed one.

xiulipan added 8 commits September 26, 2018 21:10

panic: store register PS and dump it

c59d165

The register PS will always be changed due to the IRQ disable. Store the old PS and dump that value. Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>

alloc: fix some build issues in alloc

a848c5c

Include dma.h in alloc.h will cause some error, remove the unneeded dma.h and add some need header after remove it. Also move some helper function into alloc.c to avoid some warnings. Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>

clk: add missing header

34312c0

clk will use timer function, add timer.h include for it. Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>

agent: add header for timer usage

da2f295

Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>

pm: add header fix build

fda777c

Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>

platform: fix build warning

aee5702

platform_panic is defined in platform/platform.h empty define in sof/platform.h is no use Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>

uapi: ipc: add sof_ipc_panic_info

ed2ed1e

Use sof_ipc_panic_info to store panic info inclueded filename and line number. Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>

panic: add filename and line number into panic info

f3fc87a

Add filename and line number of the panic call into the panic info. Then dump this info to host. Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>

xiulipan mentioned this pull request Sep 26, 2018

Add panic info in panic dump thesofproject/linux#162

Merged

lgirdwood requested changes Sep 26, 2018

View reviewed changes

xiulipan commented Sep 27, 2018

View reviewed changes

lgirdwood merged commit 803b4b3 into thesofproject:master Sep 27, 2018

xiulipan mentioned this pull request Oct 10, 2018

panic dump contains line number and filename #403

Closed

xiulipan deleted the panicinfo branch September 19, 2019 09:33

Conversation

xiulipan commented Sep 26, 2018

Uh oh!

xiulipan commented Sep 26, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xiulipan commented Sep 27, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lgirdwood commented Sep 27, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

xiulipan commented Sep 27, 2018 •

edited

Loading

lgirdwood commented Sep 27, 2018 •

edited

Loading