Repository navigation
Refine wait functions - #411
Merged
Merged
Conversation
|
Can one of the admins verify this patch? |
tlauda
reviewed
Sep 25, 2018
Contributor
There was a problem hiding this comment.
Instead of explicitly setting clock to SSP, maybe you should define new PLATFORM_DEFAULT_CLOCK.
PLATFORM_SCHED_CLOCK and PLATFORM_WORKQ_CLOCK can also be set to this new PLATFORM_DEFAULT_CLOCK.
Member
There was a problem hiding this comment.
@RanderWang and we should also have some doxygen comments for each new PLATFORM_ macro so users know what it does...
RanderWang
force-pushed
the
byt-master
branch
from
September 26, 2018 06:50
cd8e254 to
612e611
Compare
Collaborator
Author
|
update my patch, thanks for review |
RanderWang
force-pushed
the
byt-master
branch
from
September 26, 2018 07:41
612e611 to
b4493c6
Compare
tlauda
reviewed
Sep 26, 2018
Collaborator
Author
There was a problem hiding this comment.
thanks, updated
RanderWang
force-pushed
the
byt-master
branch
from
September 26, 2018 08:27
b4493c6 to
5d4cb92
Compare
ssp clock is used in wait_delay, so ssp clock should be used in the caller function Signed-off-by: Rander Wang <rander.wang@linux.intel.com>
Signed-off-by: Rander Wang <rander.wang@linux.intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(1) use correct clock source in wait function
(2) use wait function to wait register idle