Repository navigation
Add test reference topology for TGL nocodec - #3212
Conversation
|
@keyonjie @keqiaozhang Please help to test and review. |
b534237 to
123a951
Compare
|
@plbossart Update the PR with request. Also rename the tplg to |
123a951 to
f9ec4fb
Compare
There was a problem hiding this comment.
the name is really terrible. something like sof-tgl-nocodec-fw-eref.ri would be clearer, no?
There was a problem hiding this comment.
@plbossart Actually this tplg will include both fw echo reference and hw echo reference
xiulipan
changed the title
|
I maintain that this is an out-of-control endeavor that should be in a test topology repo, not in the topologies distributed in releases. We can't go on like this adding topology files that are for development purposes, or they belong somewhere else. |
3d6b273 to
3febf02
Compare
|
@plbossart How about still name it as nocodec? Even if it contains a lot of advanced feature, it still keep the simple nocodec pipelines |
The intention of adding this is not for development purpose, but for CI regular testing which will run on every submitted PR, it will cover more regressions finding before PRs being merged, on a single limited CI platform. @plbossart it is important for the CI coverage, IMHO. |
3febf02 to
946edf6
Compare
xiulipan
changed the title
|
@plbossart As this TPLG is only used for platform validation, we can keep the topology not merge but only use the binary from this PR. |
|
@xiulipan @keyonjie All test topologies should me merged and maintained, otherwise there's no way we can work on them as a team. That said, my point remains that we have to separate out what it used for testing and what should be packaged and used by distros. It's not right if we don't draw a clear line. We do the same for kconfigs, we have sof-defconfig and sof-dev-defconfig, and recommend distros don't use the latter. Same for topologies. |
|
@plbossart That is a good point. Can we merge this PR first as this is a blocking issue with our validation plan. I will try to do a update to the CMakefiles to add a new build target |
xiulipan
changed the title
xiulipan
changed the title
|
@plbossart @lgirdwood @keyonjie @ranj063 @singalsu Please help to review this PR to split the topology list into release and development. This will help us to manage the topologies more easily. |
There was a problem hiding this comment.
didn't we already say that this is a horrible name and this is not aligned with the kernel PR?
Really don't get what the directions are.
There was a problem hiding this comment.
@plbossart I think the kernel PR was abandoned and closed, so the naming is kept intact.
xiulipan
changed the title
To make multiple DEMUX comp can work in same topology. Add pipeline ID into the DEMUX control name. Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
Add FW echo reference to nocodec TPLG on SSP0. Add internal loopback on SSP0. We can compare echo reference and loopback capture stream. Add smart amplifier for nocodec on SSP2 Signed-off-by: Keyon Jie <yang.jie@linux.intel.com> Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
Add default dai name for dmic dai, we can override them in if dai name in machine driver is different. Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
Add KPB pipeline into the sof-tgl-nocodec-ci topology. This topology will be a reference test topology for all features used on TGL. Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
|
@plbossart @lgirdwood As we have discussed about the topology management about production and development. I will try to update this PR with a simple start up to add a @plbossart I have changed the topology to remove the dependency on Kernel PR. Do we still need some patch to nocodec machine driver to update the dai names? As this PR only provide a validation topology for our release, I did not want to involve much dependency in this PR. Can we merge this simple files first. And make alignment about what is missed and we can fix them later to do not block any release. |
Add development folder for topologies that not for production. First add sof-tgl-nocodec-ci as a validation topology. Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
4c04592 to
f323d89
Compare
|
SOFCI TEST |
keyonjie
left a comment
keyonjie
left a comment
There was a problem hiding this comment.
Thanks @xiulipan looks good to me. @plbossart how about let's proceed and ask for more development topology files clean up (being moved to the development) next.
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
Thanks @xiulipan for the dev folder. @plbossart ok for you now ?
|
ping @plbossart |
|
@lgirdwood I think we can merge this and I will send following clean up PR for the development topologies |
|
Since no objection for more than 2 weeks, let's proceed and merge it. |
Add FW echo reference to nocodec TPLG on SSP0.
Add internal loopback on SSP0. We can compare echo reference anid
loopback capture stream.
Add HW echo reference with DSM comp on SSP2
Add Keyword Detection pipelines to DMIC
merge DSM HWEchoRefernce from #3224
Signed-off-by: Pan Xiuli xiuli.pan@linux.intel.com