Skip to content

topology: add smart_amp support to sof-tgl-nocodec - #3224

Closed
keyonjie wants to merge 1 commit into
thesofproject:masterfrom
keyonjie:smart_amp_tplg
Closed

topology: add smart_amp support to sof-tgl-nocodec#3224
keyonjie wants to merge 1 commit into
thesofproject:masterfrom
keyonjie:smart_amp_tplg

Conversation

@keyonjie

@keyonjie keyonjie commented Jul 23, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Add nocodec mode smart_amp support to sof-tgl-nocodec-ci, which will help
to verify smart_amp feature on nocodec platforms.

Signed-off-by: Keyon Jie yang.jie@linux.intel.com

plbossart
plbossart requested changes Jul 23, 2020
View reviewed changes

@plbossart plbossart left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we shouldn't do this. nocodec is supposed to be a very simple solution. Put this in a different topology.

@lgirdwood

lgirdwood commented Jul 23, 2020

Copy link
Copy Markdown
Member

@keyonjie not sure how useful this is ? Unless it's helpful for the CI or kernel folks ? @aiChaoSONG @plbossart ?

@keyonjie

keyonjie commented Jul 24, 2020

Copy link
Copy Markdown
Contributor Author

we shouldn't do this. nocodec is supposed to be a very simple solution. Put this in a different topology.

Ok, let me create a new .m4 file for it.

@keyonjie

keyonjie commented Jul 24, 2020

Copy link
Copy Markdown
Contributor Author

@keyonjie not sure how useful this is ? Unless it's helpful for the CI or kernel folks ? @aiChaoSONG @plbossart ?

Yes, it is useful for CI daily automation test, we will use a test tplg file with nocodec machine driver together on TGL RVP, to verify I2S playback/capture, DMIC capture, WoV, smart_amp, (FW)Echo Ref features in CI daily test.

@keyonjie
Topology: add sof-tgl-nocodec-ci for TGL features validation with
0c12a3c 
nocodec

Add topology for Tigerlake RVP board CI testing, with covering as more
features as possible running with no codec machine.

DSM nocodec is added with this initial version.

Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>
@keyonjie
keyonjie requested a review from jajanusz as a code owner July 27, 2020 02:53
@keyonjie

keyonjie commented Jul 27, 2020

Copy link
Copy Markdown
Contributor Author

we shouldn't do this. nocodec is supposed to be a very simple solution. Put this in a different topology.

Ok, let me create a new .m4 file for it.

@plbossart updated now.

@keyonjie
keyonjie requested a review from plbossart July 27, 2020 03:02
@xiulipan

xiulipan commented Jul 27, 2020

Copy link
Copy Markdown
Contributor

Close as merged into #3212

@xiulipan xiulipan closed this Jul 27, 2020
@xiulipan xiulipan mentioned this pull request Jul 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ranj063 ranj063 Awaiting requested review from ranj063
@xiulipan xiulipan Awaiting requested review from xiulipan
@aiChaoSONG aiChaoSONG Awaiting requested review from aiChaoSONG
@bkokoszx bkokoszx Awaiting requested review from bkokoszx
@keqiaozhang keqiaozhang Awaiting requested review from keqiaozhang
@jajanusz jajanusz Awaiting requested review from jajanusz
@plbossart plbossart Awaiting requested review from plbossart

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@keyonjie @lgirdwood @xiulipan @plbossart