[jajanusz]

As in: #233
Next branch was deleted and I couldn't reopen old PR.

Split in commit, so you can easily see steps done in this refactor.
Had to be done in one pull request because separate commits will cause a lot more chaos for others while merging/rebasing.

Next we will have to deduplicate code in mentioned functions.
From now on all shared code should go to intel/cavs folders and all platform specific code will go to folder for that platform (so we will be able to get rid of ifdefs).

Signed-off-by: Janusz Jankowski janusz.jankowski@linux.intel.com

[lgirdwood]

@jajanusz will this PR break bisect ?

[jajanusz]

It's just moving/renaming/deduplicating, no stricte logic was added.
It's split into many commits and for every each commit it builds and passes unit tests.
So it shouldn't break git bisect, when you'll be looking for bugs introduced by recent merging they should be before these commits.

Please talk to @mmaka1 if you want to delay it anyway and want to ensure stability 1st. We need it not only for just sake of refactor but to make adding new platforms easier (that we want to do in few next days).

[jajanusz]

I'd be good to have #283 merged before this one, so I can apply fixes for host build (what I couldn't do cos was waiting for host buidl fix), so @singalsu will not have unnecessary work

[lgirdwood]

Not sure about the drivers_ prefix since we are using platform_ to signify the implementation is platform specific. i.e. you can easily tell that this code needs to be checked if a bug only impacts one platform only.

All the rest is fine though, just one minor comment on a variable declaration.

[lgirdwood]

len should be declared at the start of the function, to follow misra rules.

[jajanusz]

Ok. I don't like it because I have to declare unnecessary variable in function scope just to satisfy checkpatch (80 chars limit), so I wanted to limit scope at least, but if it has to be on top then it will be ;)

[lgirdwood]

Why the name change ? It's a platform specific interrupt.

[jajanusz]

I'll revert all drivers_* names changes back to platform_* names. Thanks for review

[jajanusz]

@lgirdwood
Updated as requested.
Also about bisect: i think all mv are recorded as renames in git so it shouldn't break bisect because change in file X.c that was moved to some/other/path/X.c is properly tracked in new file

So please merge PR if you have no more requests, because we need it for adding new platforms.
Thanks

[lgirdwood]

@jajanusz ok, looks good. We have a small conflict in dmic, can you fix and I'll merge. Thanks !

[jajanusz]

@lgirdwood
rebased