Repository navigation
Conversation
|
The structure of the drivers sources should reflect: //. E.g. intel/cavs/apollolake. Deploy the common sources to cavs wherever possible. Compile-time platform specific configuration of the drivers should stay in the platforms. |
Member
|
@jajanusz please also fix checkpatch comments. |
jajanusz
force-pushed
the
drivers-refactor
branch
from
August 23, 2018 09:49
26e82de to
039ec42
Compare
Split files into appropriate folders. Added makefiles to not break build. Fixed checkpatch errors in dw-dma and baytrail/ssp. Signed-off-by: Janusz Jankowski <janusz.jankowski@linux.intel.com>
Moved platform_interrupt_* functions from platform.c to interrupt.c to match CNL&APL. Updated headers for BYT&HSW to have the same functions declarations as CNL&APL. Signed-off-by: Janusz Jankowski <janusz.jankowski@linux.intel.com>
Signed-off-by: Janusz Jankowski <janusz.jankowski@linux.intel.com>
Signed-off-by: Janusz Jankowski <janusz.jankowski@linux.intel.com>
Signed-off-by: Janusz Jankowski <janusz.jankowski@linux.intel.com>
Signed-off-by: Janusz Jankowski <janusz.jankowski@linux.intel.com>
Signed-off-by: Janusz Jankowski <janusz.jankowski@linux.intel.com>
For cnl&apl removed platform_timer_register from public api and made it static. For byt&hsw moved platform_timer to platform.h (just like it is for cnl&apl). Signed-off-by: Janusz Jankowski <janusz.jankowski@linux.intel.com>
+ Indents for 'CHECK: Alignment should match open parenthesis' Signed-off-by: Janusz Jankowski <janusz.jankowski@linux.intel.com>
Signed-off-by: Janusz Jankowski <janusz.jankowski@linux.intel.com>
jajanusz
force-pushed
the
drivers-refactor
branch
from
August 29, 2018 12:28
039ec42 to
bd49c27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please wait for @mmaka1 review.
Split in commit, so you can easily see steps done in this refactor.
Had to be done in one pull request because separate commits will cause a lot more chaos for others while merging/rebasing.
Next we will have to deduplicate code in mentioned functions.
From now on all shared code should go to intel/cavs folders and all platform specific code will go to folder for that platform (so we will be able to get rid of ifdefs).
Signed-off-by: Janusz Jankowski janusz.jankowski@linux.intel.com