Skip to content

kmod: add more SoundWire codecs - #1235

Merged
marc-hb merged 1 commit into
thesofproject:mainfrom
bardliao:kmod/sdw-codecs
Oct 11, 2024
Merged

kmod: add more SoundWire codecs#1235
marc-hb merged 1 commit into
thesofproject:mainfrom
bardliao:kmod/sdw-codecs

Conversation

@bardliao

@bardliao bardliao commented Oct 9, 2024

Copy link
Copy Markdown
Contributor

rt1017-sdca and CirrusLogic missing

The CS42L43 order is inverted, the core calls into the -sdw module

@bardliao
bardliao requested a review from marc-hb October 9, 2024 03:01
@bardliao
bardliao requested review from a team and plbossart as code owners October 9, 2024 03:01
@bardliao bardliao mentioned this pull request Oct 9, 2024
Closed
@marc-hb

marc-hb commented Oct 9, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Like #1100 before it, still failing on many devices. For instance:
https://sof-ci.01.org/softestpr/PR1235/build772/devicetest/index.html?model=CML_HEL_RT5682-ipc3&testcase=check-kmod-load-unload

RMMOD	snd_hda_ext_core
RMMOD	snd_soc_core
rmmod: ERROR: Module snd_soc_core is in use by: snd_soc_wm_adsp
snd_hda_codec         204800  0
snd_hwdep              16384  1 snd_hda_codec
snd_hda_core          139264  1 snd_hda_codec
snd_soc_cs35l56_shared    32768  0
snd_soc_cs_amp_lib     16384  1 snd_soc_cs35l56_shared
snd_soc_wm_adsp        49152  0
cs_dsp                 69632  2 snd_soc_wm_adsp,snd_soc_cs_amp_lib
snd_soc_core          389120  1 snd_soc_wm_adsp
snd_compress           28672  2 snd_soc_wm_adsp,snd_soc_core
snd_pcm               217088  4 snd_hda_codec,snd_compress,snd_soc_core,snd_hda_core
snd_seq_midi           20480  0
snd_seq_midi_event     16384  1 snd_seq_midi
snd_rawmidi            53248  1 snd_seq_midi
snd_seq               110592  2 snd_seq_midi,snd_seq_midi_event
snd_seq_device         16384  3 snd_seq,snd_seq_midi,snd_rawmidi
snd_timer              49152  2 snd_seq,snd_pcm
snd                   135168  9 snd_seq,snd_seq_device,snd_hwdep,snd_hda_codec,snd_timer,snd_compress,snd_soc_core,snd_pcm,snd_rawmidi
soundcore              12288  1 snd
drm_buddy              20480  1 i915
drm_display_helper    204800  1 i915
drm_kms_helper        241664  2 drm_display_helper,i915
drm                   741376  7 i2c_hid,drm_kms_helper,drm_display_helper,drm_buddy,i915,ttm
/home/ubuntu/sof-test/tools/kmod/sof_remove.sh FAILED

Also failing in https://sof-ci.01.org/softestpr/PR1235/build769/devicetest/index.html, https://sof-ci.01.org/softestpr/PR1235/build771/devicetest/index.html

@bardliao

bardliao commented Oct 11, 2024

Copy link
Copy Markdown
Contributor Author

@marc-hb I added missing cs42l43_sdw module. But "rmmod: ERROR: Module snd_soc_core is in use by: snd_soc_wm_adsp" seems to be a different issue.

@plbossart @bardliao
kmod: add more SoundWire codecs
4ba470e 
rt1017-sdca and CirrusLogic missing

The CS42L43 order is inverted, the core calls into the -sdw module

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
@bardliao

bardliao commented Oct 11, 2024

Copy link
Copy Markdown
Contributor Author

@marc-hb I got the reason now. snd_soc_wm_adsp is used by snd_soc_cs35l56

marc-hb
marc-hb approved these changes Oct 11, 2024
View reviewed changes

@marc-hb marc-hb left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple models missing in the test results + usual LNL failures but everything is passing otherwise.

@marc-hb
marc-hb merged commit 057fbe8 into thesofproject:main Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marc-hb marc-hb marc-hb approved these changes
@plbossart plbossart Awaiting requested review from plbossart plbossart is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bardliao @marc-hb @plbossart