Repository navigation
sof_perf_analyzer: add skip-to-first-trace option - #1100
Merged
Merged
Conversation
singalsu
previously approved these changes
Sep 6, 2023
singalsu
left a comment
singalsu
left a comment
Contributor
There was a problem hiding this comment.
This patch fixes the problem that I had. Thank you very much!
marc-hb
requested changes
Sep 6, 2023
marc-hb
left a comment
marc-hb
left a comment
Collaborator
There was a problem hiding this comment.
The pylint warning may go away if you drop the too broad except?
In CI test, some traces from previous test case will apprear in the mtrace of current test case, this is a know issue. Previously, we always skip to the first valid trace of this test case, this could raise trouble for developer use of this script. This patch adds skip-to-first-trace option, for CI test, this option should be set (True), and for developer use, this option should be left as it is (False). Signed-off-by: Chao Song <chao.song@linux.intel.com>
marc-hb
previously approved these changes
Sep 7, 2023
marc-hb
left a comment
marc-hb
left a comment
Collaborator
There was a problem hiding this comment.
Nit: could you add a blank line before 190?
Note: still a Github Draft
marc-hb
reviewed
Sep 7, 2023
added 2 commits
September 7, 2023 12:20
Due to a known issue in CI test, some traces from previous test case will apprear in the mtrace of current test case. Set skip-to-first-trace option to skip those traces. Signed-off-by: Chao Song <chao.song@linux.intel.com>
The skip_to_first_trace() function either return a value or raise an exception. Currently there is no good way to do type annotation for such function, so remove its type annotation. Signed-off-by: Chao Song <chao.song@linux.intel.com>
aiChaoSONG
changed the title
aiChaoSONG
marked this pull request as ready for review
September 7, 2023 04:25
marc-hb
approved these changes
Sep 7, 2023
Author
|
Thanks Marc, the test is good, see internal result 31419, merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In CI test, some traces from previous test case will apprear in the mtrace of current test case, this is a know issue.
Previously, we always skip to the first valid trace of this test case, this could raise trouble for developer use of this script.
This patch adds skip-to-first-trace option, for CI test, this option should be set (True), and for developer use, this option should be left as it is (False).