Skip to content

kmod: add more SoundWire codecs - #1110

Closed
plbossart wants to merge 1 commit into
thesofproject:mainfrom
plbossart:kmod/sdw-codecs
Closed

plbossart wants to merge 1 commit into
thesofproject:mainfrom
plbossart:kmod/sdw-codecs

Conversation

@plbossart

Copy link
Copy Markdown
Member

rt722-sdca, rt1017-sdca and CirrusLogic missing

Note for for CirrusLogic we may have additional dependencies on MFD stuff.

@plbossart
plbossart requested a review from bardliao October 6, 2023 16:30
@plbossart
plbossart requested a review from a team as a code owner October 6, 2023 16:30
@marc-hb

marc-hb commented Oct 6, 2023 •

Copy link
Copy Markdown
Collaborator

Warning: "all checks have passed" is misleading: sof-test has NOT run yet. Internal throttling issue 480

Downgrading to draft until they have.

marc-hb
marc-hb previously approved these changes Oct 6, 2023
@marc-hb
marc-hb marked this pull request as draft October 6, 2023 16:33
@marc-hb
marc-hb marked this pull request as ready for review October 6, 2023 16:35
@marc-hb

marc-hb commented Oct 6, 2023

Copy link
Copy Markdown
Collaborator

check-kmod-load-unload.sh failures across the boards in both stable-v2.2 and cavs25

https://sof-ci.01.org/softestpr/PR1110/build777/devicetest/index.html
https://sof-ci.01.org/softestpr/PR1110/build778/devicetest/index.html

Most or maybe all of them are:

rmmod: ERROR: Module snd_soc_cs42l43_sdw is in use by: snd_soc_cs42l43

@marc-hb
marc-hb dismissed their stale review October 6, 2023 20:47

failing

@plbossart

Copy link
Copy Markdown
Member Author

@charleskeepax @rfvirgil any idea why the dependencies are different between CS42l43 and other codecs?

@charleskeepax

Copy link
Copy Markdown

The error message you state seems expected to me:

snd_soc_cs42l43 - this is the core modules holds the control bus independent code.
snd_soc_cs42l43_sdw - this is the soundwire modules holds stuff specific to soundwire.

I would expect you would need to remove the core module before you remove the soundwire one as the core calls into the soundwire code for things like dai ops. One could theoretically arrange the code the other way around but it gets really messy with having to have duplicate dai_driver struct etc.

@charleskeepax

Copy link
Copy Markdown

I guess the difference here is the actual bus level code would be the other way around (soundwire code calls the core), but since cs42l43 is an MFD the bus level code lives in MFD.

rt722-sdca, rt1017-sdca and CirrusLogic missing

The CS42L43 order is inverted, the core calls into the -sdw module

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
@plbossart

Copy link
Copy Markdown
Member Author

Thans @charleskeepax I inverted the order, let's see how things go.

@marc-hb

marc-hb commented Oct 9, 2023 •

Copy link
Copy Markdown
Collaborator

Now fails most cavs2.5 and stable-v2.2 like this:
https://sof-ci.01.org/softestpr/PR1110/build782/devicetest/index.html
https://sof-ci.01.org/softestpr/PR1110/build784/devicetest/index.html

rmmod: ERROR: Module snd_soc_core is in use by: snd_soc_wm_adsp

Just realized this test hasn't been re-added to ACE yet:

EDIT: now added. Will run again.

@marc-hb

marc-hb commented Oct 11, 2023

Copy link
Copy Markdown
Collaborator

SOFCI TEST

@marc-hb marc-hb left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now MTL/ACE is failing like the others:
https://sof-ci.01.org/softestpr/PR1110/build791/devicetest/index.html?model=MTLP_RVP_SDW&testcase=check-kmod-load-unload

RMMOD	snd_soc_core
rmmod: ERROR: Module snd_soc_core is in use by: snd_soc_wm_adsp

@fredoh9

fredoh9 commented Oct 11, 2023 •

Copy link
Copy Markdown
Contributor

SOFCI TEST

@fredoh9

fredoh9 commented Oct 11, 2023

Copy link
Copy Markdown
Contributor

new daily kernel build is available. Triggered new test again

@fredoh9

fredoh9 commented Oct 11, 2023

Copy link
Copy Markdown
Contributor

the device test is going on, no MTLP_RVP_NOCODEC. jf-mtlp-rvp-nocodec-2 had apt package tangled problem. fixed on the device

@marc-hb

marc-hb commented Oct 11, 2023

Copy link
Copy Markdown
Collaborator

Thanks @fredoh9 .

Still failing in https://sof-ci.01.org/softestpr/PR1110/build796/devicetest/index.html , https://sof-ci.01.org/softestpr/PR1110/build794/devicetest/index.html and https://sof-ci.01.org/softestpr/PR1110/build795/devicetest/index.html of course, no change

RMMOD	snd_soc_core
rmmod: ERROR: Module snd_soc_core is in use by: snd_soc_wm_adsp

@marc-hb

marc-hb commented May 9, 2024

Copy link
Copy Markdown
Collaborator

SOFCI TEST

@marc-hb

marc-hb commented May 9, 2024

Copy link
Copy Markdown
Collaborator

Still failing with rmmod: ERROR: Module snd_soc_core is in use by: snd_soc_wm_adsp across https://sof-ci.01.org/softestpr/PR1110/build411/devicetest/index.html
and in https://sof-ci.01.org/softestpr/PR1110/build410/devicetest/index.html and inhttps://sof-ci.01.org/softestpr/PR1110/build794/devicetest/index.html,...

@marc-hb
marc-hb marked this pull request as draft May 9, 2024 23:35
@marc-hb

marc-hb commented Jul 15, 2024

Copy link
Copy Markdown
Collaborator

There is a git conflict now.

@marc-hb

marc-hb commented Oct 8, 2024

Copy link
Copy Markdown
Collaborator

@bardliao could you rebase and resubmit this?

@bardliao

bardliao commented Oct 9, 2024

Copy link
Copy Markdown
Contributor

@bardliao could you rebase and resubmit this?

sure

@bardliao

bardliao commented Oct 9, 2024

Copy link
Copy Markdown
Contributor

#1235

@marc-hb marc-hb closed this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants