Repository navigation
tools: add component searching logic for tplgtool - #10
Merged
Merged
Conversation
aiChaoSONG
force-pushed
the
tplgtool
branch
2 times, most recently
from
December 19, 2019 07:54
e370a31 to
dacfd8e
Compare
Author
xiulipan
suggested changes
Jan 2, 2020
xiulipan
left a comment
xiulipan
left a comment
Contributor
There was a problem hiding this comment.
I got some question about the logic you used to get the PGA list. I think we can not get the split PGA widget from playback and capture PCM.
I think we should have some structure like this in your graph.
EG: a playback graph list for PCM0P
[PCM0P, BUF1.0, PGA1.0, BUF1.1, MIXER1.0, BUF1.2, PGA1.1, BUF1.3]
Then when you try to check what PCM0P have, it would be very easy to go through the list to get the MIXER, and PGA
Please try to change that part logic to make easy to understand and for future usage
aiChaoSONG
force-pushed
the
tplgtool
branch
2 times, most recently
from
January 6, 2020 07:06
7c9a896 to
910f243
Compare
Author
xiulipan
suggested changes
Feb 8, 2020
aiChaoSONG
force-pushed
the
tplgtool
branch
2 times, most recently
from
February 11, 2020 04:01
3317e1d to
4667cf3
Compare
aiChaoSONG
changed the title
Author
Bin-QA
suggested changes
Feb 11, 2020
aiChaoSONG
force-pushed
the
tplgtool
branch
2 times, most recently
from
February 12, 2020 06:17
8608b25 to
04a3525
Compare
xiulipan
previously approved these changes
Feb 13, 2020
xiulipan
left a comment
xiulipan
left a comment
Contributor
There was a problem hiding this comment.
some simple qustion, please add some comments in the README or comments of the tool.
This was referenced Feb 13, 2020
Contributor
|
@aiChaoSONG Could you help to rebase this patch for merge? |
xiulipan
previously approved these changes
Feb 21, 2020
This patch adds component searching logic, thus, we can get some type of components connected to a specified component. Based on the searching logic above, add a function to find componnets connected to PCM, for example, PGA and EQ. Signed-off-by: Amery Song <chao.song@intel.com>
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds component searching logic, thus, we can
get some type of components connected to a specified
component.
Based on the searching logic above, add a function to find
componnets connected to PCM, for example, PGA and EQ.