Repository navigation
test-case: add equalizer test case - #63
Merged
Merged
Conversation
fredoh9
force-pushed
the
fix/add_eq_test
branch
2 times, most recently
from
January 31, 2020 18:53
f91442a to
2c9d792
Compare
Contributor
Author
|
Updated with getting amixer control id from the system. In this case, IIR control id=23, FIR control id=24 |
Bin-QA
reviewed
Feb 3, 2020
Bin-QA
left a comment
Bin-QA
left a comment
Contributor
There was a problem hiding this comment.
I think you need change eqConfRoot as the parameter and add come description to say which file in it
because for the different platform we need to push different file, is that right?
singalsu
previously approved these changes
Feb 3, 2020
singalsu
left a comment
singalsu
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. Thanks!
libinyang
reviewed
Feb 7, 2020
Contributor
fredoh9
force-pushed
the
fix/add_eq_test
branch
2 times, most recently
from
February 27, 2020 19:24
d384134 to
108bfd5
Compare
Contributor
Author
|
@aiChaoSONG @libinyang @xiulipan I added more checking with tplgtool. I addressed your commments also. can you review again? |
libinyang
reviewed
Feb 28, 2020
xiulipan
suggested changes
Feb 28, 2020
xiulipan
left a comment
xiulipan
left a comment
Contributor
There was a problem hiding this comment.
Please make the check more easy and in right order.
Be careful with dir path and hard coded list.
All other looks good.
fredoh9
force-pushed
the
fix/add_eq_test
branch
from
March 13, 2020 01:23
1a2e493 to
f0765b6
Compare
xiulipan
suggested changes
Mar 16, 2020
xiulipan
left a comment
xiulipan
left a comment
Contributor
There was a problem hiding this comment.
The test part is OK, but we still need to refine the preparation check.
fredoh9
force-pushed
the
fix/add_eq_test
branch
2 times, most recently
from
March 17, 2020 09:06
0c4ec81 to
a9d4da1
Compare
Check currnet topology has eq components otherwise return failure. Query IIR/FIR control id from amixer and set predefined config using eqctl/*.txt. Tested with sof-apl-eq-pcm512x.tplg on APL_UP2_PCM512X. Signed-off-by: Fred Oh <fred.oh@linux.intel.com>
stripes416
approved these changes
Mar 17, 2020
stripes416
left a comment
stripes416
left a comment
Contributor
There was a problem hiding this comment.
This LGTM. Good job @fredoh9
xiulipan
approved these changes
Mar 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested with sof-apl-eq-pcm512x.tplg on APL_UP2_PCM512X.
Signed-off-by: Fred Oh fred.oh@linux.intel.com