Repository navigation
sof-test: split both type pipeline into playback and capture - #80
Merged
Merged
Conversation
aiChaoSONG
requested review from
Bin-QA,
keqiaozhang and
stripes416
as code owners
February 19, 2020 06:43
Bin-QA
reviewed
Feb 19, 2020
aiChaoSONG
force-pushed
the
split_pcm
branch
from
February 19, 2020 07:21
24c6b09 to
e5a0fc5
Compare
added 2 commits
February 19, 2020 15:22
Previously, for pcm with both playback and capture capabilities, we only output one line, and tag its type as both. This patch outputs playback and capture pipeline info separately. Signed-off-by: Amery Song <chao.song@intel.com>
Since we have split both type pcm into playback and capture pipelines, we don't need to specify "both" when obtain pipelines. This patch removes both for test cases when obtain pipelins with func_pipeline_export function. Signed-off-by: Amery Song <chao.song@intel.com>
stripes416
approved these changes
Feb 19, 2020
stripes416
left a comment
stripes416
left a comment
Contributor
There was a problem hiding this comment.
This also looks good to me @aiChaoSONG
xiulipan
approved these changes
Feb 21, 2020
xiulipan
left a comment
xiulipan
left a comment
Contributor
There was a problem hiding this comment.
Thanks for new feature. @aiChaoSONG could you help to reabase #10 for merge?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Bin-QA Wubin will modify the simultaneous-playback-capture.sh test case, and add logic to extract "both" type pipeline.
***DO NOT MERGE BEFORE PR #10 ***