Repository navigation
Fix SOF kconfigs - #445
Merged
plbossart merged 5 commits intoDec 17, 2018
Merged
Fix SOF kconfigs#445
Conversation
plbossart
requested review from
RanderWang,
bardliao,
cujomalainey,
keyonjie,
lgirdwood,
ranj063 and
xiulipan
December 14, 2018 22:41
Missing linux/io.h and linux/modules.h Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
asm/iosf-mbi.h only exists for X86, add dependency TODO: move is_byt_cr() to common helper Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
linux/pci.h is needed Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
The existing module dependencies are handled in the wrong way. We need to select first acpi/pci, then platforms and last the core. Doing otherwise would result in broken configurations where acpi/pci stuff is compiled as built-in and platforms or SOF core as a module. Rebuild Kconfig to use 'select' statements in the right order. The platform selections are now exposed with booleans only. The choice of module or built-in can now happen only at the pci/acpi/spi level, the dependencies will be compiled accordingly. As a result, "make menuconfig" does not expose how dependencies are handled. Corner cases: PCI is required for sof-pci-dev, devm_pci_enable is not defined otherwise. ACPI and SOF_INTEL_TOPLEVEL can be enabled for COMPILE_TEST Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
s/SND_SOF_SOC_INTEL/SND_SOC_SOF_INTEL_TOPLEVEL Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
plbossart
force-pushed
the
fix/friday-janitor-work
branch
from
December 15, 2018 04:02
eb6cce1 to
2ad71b9
Compare
RanderWang
reviewed
Dec 17, 2018
RanderWang
left a comment
RanderWang
left a comment
There was a problem hiding this comment.
Do we need to add CONFIG_X86 for header files of intel?
#ifdef CONFIG_X86
/* platform specific devices */
#include "intel/shim.h"
#include "intel/hda.h"
#endif
| @@ -10,6 +10,7 @@ | |||
|
|
|||
| #include <linux/firmware.h> | |||
There was a problem hiding this comment.
do we need to refine following header files for intel?
#ifdef CONFIG_X86
/* platform specific devices */
#include "intel/shim.h"
#include "intel/hda.h"
#endif
RanderWang
reviewed
Dec 17, 2018
Member
Author
|
On 12/17/18 12:57 AM, RanderWang wrote:
***@***.**** commented on this pull request.
Do we need to add CONFIG_X86 for header files of intel?
Not in general, I only added CONFIG_X86 for a specific case where an
architecture-specific include can only be found with X86 defined.
We do want to try and compile with non-x86 compilers, even if this does
not result in functional code but might catch some bugs or missing
definitions.
|
Member
Author
|
No objection so merging now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #443
New kconfigs are needed for this (already available at thesofproject/kconfig@ac4824c)
Please check, test and let me know if you find any regression.
There's no code change so it should be transparent