Repository navigation
topology: widget not found for codec during loading topology on BYT with ALC5651. #474
Copy link
Copy link
Closed
Labels
BYTApplies to Baytrail platformApplies to Baytrail platformP1Blocker bugs or important featuresBlocker bugs or important featuresbugSomething isn't workingSomething isn't working
Description
Summary:
The widget was not found for codec during loading topology on BYT with ALC5651.
sof-logger is empty. sof-logger -t log is attached below.
dmesg:
[ 7.084737] sof-audio sof-audio: tplg: config SSP2 fmt 0x4001 mclk 19200000 bclk 1920000 fclk 48000 width (16)20 slots 2 mclk id 0
[ 7.084776] sof-audio sof-audio: ipc tx: 0x80010000: GLB_DAI_MSG: CONFIG
[ 7.084855] sof-audio sof-audio: ipc tx succeeded: 0x80010000: GLB_DAI_MSG: CONFIG
[ 7.084869] sof-audio sof-audio: ASoC: Parent card not yet available, widget card binding deferred
[ 7.084872] sof-audio sof-audio: tplg: complete pipeline PIPELINE.2.SSP2.IN id 11
[ 7.084884] sof-audio sof-audio: ipc tx: 0x30130000: GLB_TPLG_MSG: PIPE_COMPLETE
[ 7.084958] sof-audio sof-audio: ipc tx succeeded: 0x30130000: GLB_TPLG_MSG: PIPE_COMPLETE
[ 7.084966] sof-audio sof-audio: tplg: complete pipeline PIPELINE.1.SSP2.OUT id 5
[ 7.084977] sof-audio sof-audio: ipc tx: 0x30130000: GLB_TPLG_MSG: PIPE_COMPLETE
[ 7.085031] sof-audio sof-audio: ipc tx succeeded: 0x30130000: GLB_TPLG_MSG: PIPE_COMPLETE
[ 7.086021] rt5651 i2c-10EC5651:00: Warning: Invalid over-current-threshold-microamp value: 0, defaulting to 2000uA
[ 7.086496] bytcr_rt5651 bytcr_rt5651: ASoC: no source widget found for codec_out0
[ 7.086592] bytcr_rt5651 bytcr_rt5651: ASoC: Failed to add route codec_out0 -> direct -> ssp2 Tx
[ 7.086687] bytcr_rt5651 bytcr_rt5651: ASoC: no source widget found for codec_out1
[ 7.086767] bytcr_rt5651 bytcr_rt5651: ASoC: Failed to add route codec_out1 -> direct -> ssp2 Tx
[ 7.086800] sof-audio sof-audio: ipc rx: 0x90020000: GLB_TRACE_MSG
[ 7.086861] bytcr_rt5651 bytcr_rt5651: ASoC: no sink widget found for codec_in0
[ 7.086879] sof-audio sof-audio: ipc rx done: 0x90020000: GLB_TRACE_MSG
[ 7.086938] bytcr_rt5651 bytcr_rt5651: ASoC: Failed to add route ssp2 Rx -> direct -> codec_in0
[ 7.087031] bytcr_rt5651 bytcr_rt5651: ASoC: no sink widget found for codec_in1
[ 7.087108] bytcr_rt5651 bytcr_rt5651: ASoC: Failed to add route ssp2 Rx -> direct -> codec_in1
[ 7.087240] bytcr_rt5651 bytcr_rt5651: ASoC: failed to init SSP2-Codec: -19
[ 7.087323] bytcr_rt5651 bytcr_rt5651: ASoC: failed to instantiate card -19
[ 7.087399] sof-audio sof-audio: free topology...
[ 7.087407] sof-audio sof-audio: error: failed to find dai Passthrough
[ 7.087577] bytcr_rt5651 bytcr_rt5651: devm_snd_soc_register_card failed -19
[ 7.587122] sof-audio sof-audio: ipc rx: 0x90020000: GLB_TRACE_MSG
[ 7.587157] sof-audio sof-audio: ipc rx done: 0x90020000: GLB_TRACE_MSG
Test env:
sof master: 8e1249c
kernel sof-dev: cac0c10
tplg: test-ssp2-mclk-0-I2S-volume-s16le-s16le-48k-19200k-codec.tplg-ad3f3e4f
Jiang Xin's bisect result :
Success on linux pr457(commitID: a4364e07)
Failed on linux pr448-2 (commitID: e9f05c00):
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
BYTApplies to Baytrail platformApplies to Baytrail platformP1Blocker bugs or important featuresBlocker bugs or important featuresbugSomething isn't workingSomething isn't working
Activity
wenqingfu commentedon Dec 19, 2018
appreciated! 👍
plbossart commentedon Dec 19, 2018
the last commit is an artificial one that doesn't match any of the PRs I merged.
Can we please do a git bisect on topic/sof-dev to point to a specific issue.
mengdonglin commentedon Dec 29, 2018
@Jiangxinx @markyang Could you help to follow up Pierre's request?
#457 is closed without being merged.
So if the case failled with https://github.com/thesofproject/linux/pull/448/commits (merged on Dec 17), you may check the daily building image the previous day and do a git bisect.
xun2z commentedon Jan 4, 2019
This issue is caused by the Pull Request #445.
The kconfig "SND_SOC_SOF_INTEL" is changed to "SND_SOC_SOF_INTEL_TOPLEVEL", while some dependent machine drivers still use the old one. In
cht_bsw_rt5672.c
cht_bsw_rt5645.c
cht_bsw_max98090.ti.c
bytcr_rt5651.c
bytcr_rt5640.c
bytcht_rt7213.c
the statement
#if !IS_ENABLED(CONFIG_SND_SOC_SOF_INTEL)mengdonglin commentedon Jan 5, 2019
@plbossart could you add @xun2z to this project? I cannot assign the bug to him
mengdonglin commentedon Jan 5, 2019
#502 is to fix this issue.
@xun2z please update here if your revised PR get merged.
plbossart commentedon Jan 7, 2019
@mengdonglin please assign this issue to either @markyang or @xun2z, i don't know why this was assigned to me.
markyang commentedon Jan 7, 2019
@stevyan
wenqingfu commentedon Jan 10, 2019
I did it because it's root caused to #445 which you're the author. That's why.
xun2z commentedon Jan 11, 2019
sof part to fix the bug is here
thesofproject/sof#803
markyang commentedon Jan 11, 2019
@xun2z
Summary:
This issue can still be reproduced on BYT with ALC5651 using the latest build.
dmesg:
Test env:
sof master: 9ef3826
kernel sof-dev: 39d9015
tplg: test-ssp2-mclk-0-I2S-volume-s16le-s16le-48k-19200k-codec.tplg & sof-byt-rt5651.tplg (Both tplgs don’t work)
xun2z commentedon Jan 11, 2019
@markyang
Yes, we are still working on the sof part to prevent all these kernel warnings.
In kernel part, we just removed SOF-dependent statements in case we may see some strange errors when we modify the kconfigs.
After sof thesofproject/sof#803 is merged, sof-byt-rt5651.tplg can work. test-ssp2-mclk-0-I2S-volume-s16le-s16le-48k-19200k-codec.tplg will not work well since we only add some virtual widgets in byt and cht machines.
plbossart commentedon Jan 11, 2019
Sorry, if you added the virtual widgets in byt.m4 then all topology files would inherit those definitions, including the test topologies. What am I missing?
xun2z commentedon Jan 12, 2019
@plbossart
I tested this test tplg on byt with alc5651, still got the error messages.
I will do a double check, maybe I've missed something.
xun2z commentedon Jan 14, 2019
@plbossart
test-ssp2-mclk-0-I2S-volume-s16le-s16le-48k-19200k-codec.tplg works
markyang commentedon Jan 15, 2019
Summary:
This issue was fixed by #502 & thesofproject/sof#803, cannot be reproduced on BYT with ALC5651.
Test env:
sof master: a334567
kernel sof-dev: 8ba1140
tplg: test-ssp0-mclk-0-I2S-volume-s16le-s16le-48k-24000k-codec.tplg
net: do not reuse skbuff allocated from skbuff_fclone_cache in the sk…
btrfs: fix error propagation of split bios