Skip to content

Kconfigs: bad dependencies between PCI/ACPI and platform drivers #443

Closed

Description

@plbossart

In the existing Kconfig, each platform device will select ACPI or PCI, e.g.

config SND_SOC_SOF_BAYTRAIL
	tristate "SOF support for Baytrail, Braswell and Cherrytrail"
	select SND_SOC_SOF_ACPI

This is problematic because the dependencies are in the opposite order. sof-acpi-dev.c makes references to BYT/CHT/HSW/BDW descriptors, and if sof-acpi-dev.c is compiled as built-in we cannot have the descriptors part of a module.

we need to revert the selections so that the mode used for sof-acpi/pci-dev is propagated.

Reported by kbuild with the following .config (renamed for inclusion in github). Even if SOF won't work with built-ins for now, this needs to be fixed before upstream or we will have tons of reports of broken randconfigs.

dot.config.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions