Skip to content

Feedback from RT1011 - channels are swapped at every session #1838

Closed

Description

@sathyap-chrome

On CML platform, we have RT1011 smart amp providing feedback. we have 4 CH feedback ( from 4 individual speakers) enabled with attached Topology ( m4 is attached too)

Test procedure:
Play a known audio sample ( preferably sine tone) on Speakers
Record 4 ch data on Feedback PCM ( hw:0,10) for few seconds and make multiple recordings.
Each file shows feedback to be different - ideally they should be same for same input file.

TEST ENV:
CML device with RT1011 Amp.
SOF v0.8 backport release FW and topology changes attached on top.

008_aec.zip

Activity

  1. sathyap-chrome commented on Feb 28, 2020

    @sathyap-chrome
    Author

    @keqiaozhang Please reproduce one time and then we can see how to proceed debug. Codec vendor informs that the codec side, there is no channel swap.

    cc @keyonjie @aiChaoSONG

  2. keyonjie commented on Mar 2, 2020

    @keyonjie

    @sathyap-chrome can you help clarify:

    1. you are playing stereo(2 channels) sine wav output to speakers,

    2. you are capturing 4 channels(actually only channel 0/1 has data input) which expected the channel 0/1 getting the exact output of the playback channel 0/1 and 0s at channel 2/3.

    3. is it possible to probe the output/input on the SSP pins on your side?

    Hi @aiChaoSONG @keqiaozhang let's try if we can reproduce it on our side.

  3. aiChaoSONG commented on Mar 2, 2020

    @aiChaoSONG

    @keyonjie could you please have a look at thesofproject/sof#2430, and see if this merged PR has any influence on the abnormal behavior mentioned in this issue?

  4. sathyap-chrome commented on Mar 2, 2020

    @sathyap-chrome
    Author

    @keyonjie

    you are playing stereo(2 channels) sine wav output to speakers

    Yes

    you are capturing 4 channels(actually only channel 0/1 has data input) which expected the channel 0/1 getting the exact output of the playback channel 0/1 and 0s at channel 2/3

    . Its a 4 CH capture since there are 4 individual codecs configured ( 1 in each TDM slot )
    Hence feedback will have data on all 4 channels.
    The 4 individual codecs play 2 CH playback but provide feedback individually.
    Refer TDM slot mapping here:

    1. is it possible to probe the output/input on the SSP pins on your side?
      I can try. But i wanted to know if we can get a dump or some s/w means to easily debug without opening up the closed chassis machine.
      Also easy for codec vendors to duplicate any debug points.

    @aiChaoSONG I guess not. This issue was seen with SOFv0.7 as well as SOF v0.8.

  5. keyonjie commented on Mar 2, 2020

    @keyonjie

    @keyonjie could you please have a look at thesofproject/sof#2430, and see if this merged PR has any influence on the abnormal behavior mentioned in this issue?

    the PR is to divide playback/capture channel numbers, I believe it won't fix channel swapping issue.

  6. keyonjie commented on Mar 2, 2020

    @keyonjie

    @sathyap-chrome can you help upload the playback and captured .wav files?

  7. sathyap-chrome commented on Mar 2, 2020

    @sathyap-chrome
    Author

    This has 2 captured files. playback for this case was just normal music playback.
    008_aec.zip

    If you need sinewave for testing, here it is -

    left1KHz_right777Hz.zip

    I'll send out the captures from this file in a few minutes

  8. aiChaoSONG commented on Mar 2, 2020

    @aiChaoSONG

    On sof-dev + master, seems reocrd nothing. @sathyap-chrome @keyonjie
    record4ch

  9. sathyap-chrome commented on Mar 2, 2020

    @sathyap-chrome
    Author

    @aiChaoSONG did you make the topology modification ?
    I've shared the tplg and also m4 for reference . You need to test only on the Helios device.

    Can you try the SOF 0.8 backport on chrome first ?

  10. aiChaoSONG commented on Mar 2, 2020

    @aiChaoSONG

    @keyonjie @sathyap-chrome result on 008 backport(Chrome OS) is below.
    recorded4ch4

    @sathyap-chrome @keyonjie Now, I understand what the issue is. the wave seems on different channel slot at each recording.

  11. sathyap-chrome commented on Mar 2, 2020

    @sathyap-chrome
    Author

    @aiChaoSONG please do multiple recordings (during same playback) and check the snaphot.. above is only 1 recording, we need to compare 2 recording.

  12. keyonjie commented on Mar 2, 2020

    @keyonjie

    @keyonjie @sathyap-chrome result on 008 backport(Chrome OS) is below. some phase shift?
    recrodedwave
    record4ch.zip

    @aiChaoSONG did you play the left1KHz_right777Hz file Sathya shared?

  13. aiChaoSONG commented on Mar 2, 2020

    @aiChaoSONG

    @keyonjie The problem is here: we have two channel with sound, and there are 4 recording channels, the two with sound distribute randomly on the 4 recording channels. sometimes on ch1&ch2, sometimes on ch1&ch4. you can see the picture I attached above. file used for playback is the one Sathya shared.

  14. sathyap-chrome commented on Mar 2, 2020

    @sathyap-chrome
    Author

    @aiChaoSONG this is correct 👍 #1838 (comment)

    The feedback should actually get data from SSP Rx and its mapped to codec.
    there are 4 individual channels on feedback. its not a playback loopback. if its behaving the way you mentioned, its actually incorrect.

  15. keyonjie commented on Mar 2, 2020

    @keyonjie

    @sathyap-chrome @aiChaoSONG let's try to verify if the issue exist with hardware loopback mode(codec playback output jack connected to capture input jack).

  16. 29 remaining items

  17. aiChaoSONG commented on May 18, 2020

    @aiChaoSONG

    @keyonjie Yes, daily and PR tests run on this platform everyday,

  18. sathyap-chrome commented on Jul 15, 2020

    @sathyap-chrome
    Author

    Hi @keyonjie @aiChaoSONG due to other priorities i couldnt do any debug on this one.
    I have some info from my test using CML 008 release :
    I'm attaching the TPLG, m4 file the feedback wav snapshot and asoc graph here.

    008_aec_ww29.zip

    Note that the feedback is swapped as per the original issue. But interestingly i see that the pipeline for SSP1.IN is not active during my record session in both sessions.

    Can you help replicate this issue on latest master ? this can help debug this faster.
    any suggestions on what can be next debug step.

  19. aiChaoSONG commented on Sep 4, 2020

    @aiChaoSONG

    @keyonjie @sathyap-chrome Hi, Sathya, I tried the topology attached with the latest kernel and FW, there is nothing in the recorded feedback wave.

  20. sathyap-chrome commented on Sep 4, 2020

    @sathyap-chrome
    Author

    Hi @aiChaoSONG this is what i also observed . Hence we are not able to use the dump to check the SSP Rx data. Note that with CML v0.8, the feedback has data.

  21. keyonjie commented on Sep 14, 2020

    @keyonjie

    Hi @sathyap-chrome Thanks for the feedback, so how urgent is this now?

  22. added
    P3Low-impact bugs or features
    and removed
    P2Critical bugs or normal features
    on Sep 15, 2020
  23. keyonjie commented on Sep 27, 2020

    @keyonjie

    Hi, @sathyap-chrome can you help to try if PR thesofproject/sof#3476 help for this issue?

  24. plbossart commented on Jan 22, 2021

    @plbossart
    Member
  25. keyonjie commented on Jan 22, 2021

    @keyonjie

    since thesofproject/sof#3476 already merged, so if either @sathyap-chrome or @aiChaoSONG re-check it with master firmware to confirm it, we can close it.

  26. aiChaoSONG commented on Jan 22, 2021

    @aiChaoSONG

    @keyonjie I remembered that I have tried to check this issue on master with the topology provided, no data recorded via feedback pipeline.

  27. plbossart commented on Jun 10, 2021

    @plbossart
    Member

    It's unclear if this bug is current or not. I will close, if this is an error @sathyap-chrome @aiChaoSONG @keyonjie please reopen with a status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

CMLApplies to Comet Lake platformChromeRelated to Chrome integrationI2SP3Low-impact bugs or featuresbugSomething isn't working

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions