Repository navigation
dai: add dir arg to get_hw_params function in dai_ops - #2430
Merged
lgirdwood merged 3 commits intoFeb 26, 2020
Merged
Conversation
Hardware stream parameters can be different for PLAYBACK and CAPTURE direction. get_hw_params() should return parameters correctly depending on the stream direction. Signed-off-by: Bartosz Kokoszko <bartoszx.kokoszko@linux.intel.com>
Hardware stream parameters can be different for PLAYBACK and CAPTURE direction. dai_get_hw_params() should return parameters corretly depending on the stream direction. Signed-off-by: Bartosz Kokoszko <bartoszx.kokoszko@linux.intel.com>
FOR ssp channels parameter can be different for PLAYBACK and CAPTURE and it depends on tx_slots and rx_slots config variables. This commit utilizes those variables in get_hw_params() function in order to return hardware stream parameters correctly. Signed-off-by: Bartosz Kokoszko <bartoszx.kokoszko@linux.intel.com>
bkokoszx
requested review from
RanderWang,
dbaluta,
jajanusz,
lbetlej,
lgirdwood,
mmaka1,
plbossart,
singalsu and
tlauda
as code owners
February 24, 2020 23:13
lgirdwood
approved these changes
Feb 25, 2020
jajanusz
approved these changes
Feb 25, 2020
dbaluta
approved these changes
Feb 25, 2020
paulstelian97
approved these changes
Feb 25, 2020
Member
|
Internal CI is showing a regression from a previous commit that needs to be bisected. This is a fix so should improve the CI results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardware stream parameters can be different for
PLAYBACK and CAPTURE direction. get_hw_params()
and dai_get_hw_params() function should return
parameters correctly depending on the stream direction.