Skip to content

[SDW][BUG]Pop noise occurred when do pause/release or switch to background/foreground during aplay0,0(RT711) or aplay0,2(RT1308) #1376

New issue
New issue
Closed
Closed
[SDW][BUG]Pop noise occurred when do pause/release or switch to background/foreground during aplay0,0(RT711) or aplay0,2(RT1308)#1376
Labels
CMLApplies to Comet Lake platformSDWApplies to SoundWire bus for codec connectionbugSomething isn't workingcodecCodec HW or driver restrictionwon't fixThis will not be worked on atm (e.g. a bug closed for lack of user request, hardware etc)

Description

@YvonneYang2
YvonneYang2
opened on Oct 25, 2019

Describe the bug
Pop noise occurred when do pause/release or switch to background/foreground during aplay0,0(RT711) or aplay0,2(RT1308)

To Reproduce

  1. Boot up.
  2. Aplay 0,2 via "aplay -Dhw:0,2 -r48000 -c2 -fs16_le wav/48California_Dreaming.wav -vv -i"
  3. PUSH_PAUSE and PUSE_RELEASE. Interval time between pause/release is about 0.5s

frequency
Not each PUSH_RAUSE/PUSH_RELEASE will occur pop noise. Pause/release 10 times, reproduced 5 times.

Expected result
Pause/release has no pop noise.

Actual result
Pause/release will have pop noise.

Environment
kernel: https://github.com/thesofproject/linux/tree/integration/soundwire-latest commit: 15f27d8 + PR1359
FW: https://github.com/thesofproject/sof/commits/master commit: 89ef0af
tplg: Same with FW branch, sof-cml-rt711-rt1308-rt715.tplg
platform: CML SDW Laptop with ALC711+ ALC1308+ ALC715

dmesg.log
logger.log

Activity

  1. YvonneYang2
    added
    bugSomething isn't working
    CMLApplies to Comet Lake platform
    on Oct 25, 2019

  2. plbossart commented on Oct 25, 2019

    @plbossart
    plbossart
    on Oct 25, 2019
    Member

    @YvonneYang2 I don't think there's anything we can do to avoid pops/clicks if there is an underflow during playback.

    For pops for pause push/resume, this also goes back to the 'feature'. We will not have the ability to do a ramp down/up, so I don't think we can prevent such issues from happening due to discontinuites between samples. This is a standard audio problem, for me this is not a bug we can fix. It is what it is.

    @bardliao please chime in.

  3. YvonneYang2
    added
    SDWApplies to SoundWire bus for codec connection
    on Oct 28, 2019
  4. mengdonglin
    added
    codecCodec HW or driver restriction
    on Oct 28, 2019

  5. mengdonglin commented on Oct 28, 2019

    @mengdonglin
    mengdonglin
    on Oct 28, 2019

    Realtek will check this issue

  6. bardliao commented on Oct 28, 2019

    @bardliao
    bardliao
    on Oct 28, 2019
    Collaborator

    It looks like a depop issue on codec and @shumingfan can reproduce the issue on his side. He will look into it.

  7. shumingfan commented on Oct 28, 2019

    @shumingfan
    shumingfan
    on Oct 28, 2019

    Hi all, please try to apply the PR #1385 and test again.

  8. YvonneYang2 commented on Oct 29, 2019

    @YvonneYang2
    YvonneYang2
    on Oct 29, 2019
    Author

    Issue can still be reproduced on CML laptop.

    Test recipe:
    kernel: https://github.com/thesofproject/linux/tree/integration/soundwire-latest commit: 661d261 + PR #1385 + eea6126
    FW: https://github.com/thesofproject/sof/commits/master commit: 0e8cf66
    tplg: https://github.com/bardliao/sof/commits/soundwire-tplg (commit: 0408153), sof-cml-rt711-rt1308-rt715.tplg
    platform: CML SDW Laptop with ALC711+ ALC1308+ ALC715

    Logs:
    dmesg.log
    logger.log

  9. shumingfan commented on Oct 29, 2019

    @shumingfan
    shumingfan
    on Oct 29, 2019

    @YvonneYang2 Oh, I notice how do you reproduce this issue. This test method doesn't close/reopen the process of playback. The pop noise shouldn't come from the codec.
    You could try to play the silence data to test it and that will proof my explanation.
    "aplay -Dhw:0,2 -r48000 -c2 -fs16_le /dev/zero -vv -i"
    I tested it and can't hear the pop noise.

    I did the patches yesterday that fixed the pop noise while the playback off.

  10. YvonneYang2 commented on Oct 29, 2019

    @YvonneYang2
    YvonneYang2
    on Oct 29, 2019
    Author

    Test with latest soundwire-latest (661d261)+ #1385 + eea6126 and master (0e8cf66) branch, issue still reproduced when pause/release on "Aplay 0,2 via "aplay -Dhw:0,2 -r48000 -c2 -fs16_le wav/48California_Dreaming.wav -vv -i"

    @shumingfan
    Yes, confirmed that "aplay -Dhw:0,2 -r48000 -c2 -fs16_le /dev/zero -vv -i" cannot reproduce the issue with or without #1385 .

  11. plbossart commented on Oct 30, 2019

    @plbossart
    plbossart
    on Oct 30, 2019
    Member

    @YvonneYang2 I don't think we can fix further, this should be tagged as closed or won't fix.

  12. YvonneYang2
    added
    won't fixThis will not be worked on atm (e.g. a bug closed for lack of user request, hardware etc)
    on Oct 31, 2019

  13. YvonneYang2 commented on Oct 31, 2019

    @YvonneYang2
    YvonneYang2
    on Oct 31, 2019
    Author

    Won't fix it since it's a standard audio problem.

  14. YvonneYang2
    closed this as completedon Oct 31, 2019

  15. YvonneYang2 commented on Nov 7, 2019

    @YvonneYang2
    YvonneYang2
    on Nov 7, 2019
    Author
    1. Play a video, do pause/release, issue cannot be reproduced.
    2. Paplay via "paplay test.wav" , switch to background and back to foreground, issue also cannot be reproduced.
    3. Suspend with deep mode when system is idle with headphone connected, will has one pop noise. (s2idle mode is blocked by [BUG][s2idle] IPC error after pause_push/S0 idle/resume/pause_release #1387)

    Test recipe:
    kernel: https://github.com/thesofproject/linux/tree/integration/soundwire-latest commit: 35dd388
    FW: https://github.com/thesofproject/sof/commits/master commit: 9844920
    tplg: same path as FW branch, sof-cml-rt711-rt1308-mono-rt715.tplg
    platform: CML SDW Laptop with ALC711+ ALC1308+ ALC715

  16. plbossart commented on Nov 7, 2019

    @plbossart
    plbossart
    on Nov 7, 2019
    Member

    @YvonneYang2 is this the right bug? You closed this 7 days ago?

  17. libinyang commented on Mar 5, 2020

    @libinyang
    libinyang
    on Mar 5, 2020

    We found starting or stopping (ctrlC) playback in aplay will also meet a similar issue. I'm not sure if it is the same bug with this issue. I suggest we reopen this issue or maybe better to open a new bug for aplay starting or stopping with ctrlC.

  18. mengdonglin commented on Mar 6, 2020

    @mengdonglin
    mengdonglin
    on Mar 6, 2020

    Seems to the same issue to thesofproject/sof#2203

  19. mengdonglin
    reopened this on Mar 6, 2020

  20. YvonneYang2 commented on Mar 6, 2020

    @YvonneYang2
    YvonneYang2
    on Mar 6, 2020
    Author

    Split background/foreground scenario to #1866
    Split terminate via "Ctrl+c" scenario to #1865
    Split Start scenario to #1867
    Split pause/resume secnario to #1869

  21. plbossart
    closed this as completedon May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    CMLApplies to Comet Lake platformSDWApplies to SoundWire bus for codec connectionbugSomething isn't workingcodecCodec HW or driver restrictionwon't fixThis will not be worked on atm (e.g. a bug closed for lack of user request, hardware etc)

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions