Skip to content

[BUG][CML] Pulse Noise on speaker pipeline in pause/release test #2203

Closed

Description

@aiChaoSONG

Describe the bug
run aplay via speaker pipeline, and press Space to pause/release playback, you can here pulse noise(sounds like "pa"). check dmesg and sof-logger, no clear errors found.

To Reproduce

  1. run aplay -Dhw:0,5 -f dat -i -vvv -c 2 ./longwave.wav
  2. Press SPACE to pause/release playback

MAKE SURE WAVE FILE CAN OUTPUT SOUND, DO NOT PLAY /dev/zero

if not reproduced with above procedures, please try the script attached. Because the sound of press space may cover the pulse noise.

Reproduced Rate
should be very easy to reproduce on the platform described below

Environment

  1. Branch name and commit hash of the 2 repositories: sof (firmware/topology) and linux (kernel driver).
  2. Name of the topology file
    • Topology: {sof-cml-rt1011-rt5682.tplg}
  3. Name of the platform(s) on which the bug is observed.
    • Platform: {CML with rt5682 and rt1011 codecs}

Error Logs
No clear error seen in logs

sof-test-pause-release.zip
spk_pulse_noise_pause_release_soflogger.log
spk_pulse_noise_pause_release_dmesg.log

Activity

  1. added
    bugSomething isn't working as expected
    CMLApplies to Comet Lake platform
    on Dec 13, 2019
  2. lgirdwood commented on Dec 16, 2019

    @lgirdwood
    Member

    @aiChaoSONG can you paste in audacity screenshots showing the pop (palying sine wave). Please also attach small wavs of pop during sine wave.

  3. aiChaoSONG commented on Dec 18, 2019

    @aiChaoSONG
    CollaboratorAuthor

    @lrgirdwo @mmaka1 I run some test with nocodec tplg, and the pause/release interval is 0.2s, and there is surely some pulse here, please see the picture and attached wave. seems we lost some samples. but if we change pause/release interval to 0.5s, things are much better, see attached wave.
    spk_pulse_2
    speaker
    speaker_pulse_noise
    headset_interval_0.2s.zip
    headset_interval_0.5s.zip

  4. lgirdwood commented on Dec 18, 2019

    @lgirdwood
    Member

    @aiChaoSONG potentailly looks like stale data in the DAI FIFO (that's replayed at unpuase). What interface HDA, SSP are you playing from ?
    @tlauda it could be we are pausing the DAI prior to FIFO being empty ?

  5. aiChaoSONG commented on Dec 19, 2019

    @aiChaoSONG
    CollaboratorAuthor

    @lgirdwood , it's SSP

  6. lgirdwood commented on Dec 19, 2019

    @lgirdwood
    Member

    @tlauda SSP trailing bytes ?

  7. self-assigned this
    on Feb 11, 2020
  8. tlauda commented on Mar 13, 2020

    @tlauda
    Contributor

    @ktrzcinx @aiChaoSONG I see some fixes have been merged. Do you still see the issue?

  9. aiChaoSONG commented on Mar 13, 2020

    @aiChaoSONG
    CollaboratorAuthor

    @tlauda I can not hear the noise, but we still have very tiny amount of data lost, if this doesn't matter, we can close this now.
    Screenshot from 2020-03-13 17-03-11

  10. tlauda commented on Mar 13, 2020

    @tlauda
    Contributor

    @aiChaoSONG This is expected on SSP. Transfer can end in the middle of the link list item and next one starts from the next item, so some small amount of data is lost.

  11. aiChaoSONG commented on Mar 13, 2020

    @aiChaoSONG
    CollaboratorAuthor

    @tlauda Fine, let's close this.
    close for fixed by #2364

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

CMLApplies to Comet Lake platformP3Low-impact bugs or featuresbugSomething isn't working as expected

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions