Repository navigation
[SDW][BUG]Pop noise occurred when terminate aplay0,2(RT1308) or aplay0,0(RT711) via "Ctrl+C" #1865
Description
Describe the bug
Pop noise occurred when terminate aplay0,2(RT1308) or aplay0,0(RT711) via Ctrl-C.
To Reproduce
- Boot up.
- Aplay 0,2 via "aplay -Dhw:0,2 -r48000 -c2 -fs16_le wav/48California_Dreaming.wav -vv -i"
- Terminate it by "Ctrl+C". If issue not reproduced, please try step2/3 more times.
frequency
Not each terminate will occur pop noise. Do step2/3 10 times, could reproduce about 5 times.
Expected result
Terminate it via "Ctrl+C" has no pop noise.
Actual result
Terminate it via "Ctrl+C" has pop noise.
Environment
Kernel:release/sdw_cml_hotfix, commit:38d0dcd
FW: commits/cml-010-hot-fix, commit: 0ed0dba
tplg: Same with FW branch, sof-cml-rt711-rt1308-mono-rt715.tplg
platform: CML-U Laptop with ALC711+ ALC1308+ ALC715 in SDW mode
ucm: https://github.com/thesofproject/alsa-ucm-conf.git+PR#24 or PR#28
Activity
[-]v[SDW][BUG]Pop noise occurred when terminate aplay0,2(RT1308) or aplay0,0(RT711) via Ctrl-C[/-][+][SDW][BUG]Pop noise occurred when terminate aplay0,2(RT1308) or aplay0,0(RT711) via "Ctrl+C"[/+]YvonneYang2 commentedon Mar 6, 2020
Tested with nocodec tplg, please see the picture and attached wave.
sinahuang commentedon Mar 6, 2020
Issue also can be reproduced on CML-H Laptop with codec ALC711, 2 x RT1308, RT715 in SDW mode, but can't be reproduced on TGL-U RVP with codec ALC711 in SDW mode and RT1308 in I2S mode.
plbossart commentedon Mar 6, 2020
@YvonneYang2 does this happen with the master branches for fw and kernel?
I don't know if we have a good solution, when playback is interrupted the link remains on for some time but the data transfers will stop abruptly. Even if we push zeroes on the link we'd still have discontinuities so maybe this is an amplifier issue.
@shumingfan @bardliao what do you think?
bardliao commentedon Mar 9, 2020
@plbossart I can see this issue with latest kernel and fw code. And it happens not only when terminate but also start. The pop doesn't sound like discontinuities. The pop is much louder than the music if I set the volume to a very low level. However, there is no pop if I play with /dev/zero.
YvonneYang2 commentedon Mar 9, 2020
Error still seen when playing same level audio file
shumingfan commentedon Mar 9, 2020
@plbossart I want to do a silent playback test and @bardliao had completed it. If there is no pop with this test, I think the pop noise doesn't come from the codec.
YvonneYang2 commentedon Mar 9, 2020
Checked on latest sof-dev + master, still can produce it.
Then tried headset loopback noise, got the snapshot and wav.
Sine wav:
sinewave.zip
Same level wav:
samelevel.zip
ClarexZhou commentedon Mar 16, 2020
Error is much improved with PR#1897. But still has very light pop via scenario "pause aplay first then Ctl+c to release aplay". Can observe this pop sound when increase speaker volume to Max via PGA3.0 3
Tested with kernel sof-dev, commit: 0f90705, contains PR #1887 + PR #1897 and FW: https://github.com/thesofproject/sof/tree/cml-010-hot-fix, commit thesofproject/sof@0ed0dba + commit thesofproject/sof@f73332e
And with same kernel sof-dev, commit: 0f90705, contains PR #1887 + PR #1897 and FW: Master, commit: thesofproject/sof@afd9770,
YvonneYang2 commentedon Apr 22, 2020
Since #1897 has been merged, retest it om cml-u laptop, issue cannot be reproduced with latest sof-dev(8dc1789) and master(0befebb). Close it.