Skip to content

[enhancement] Use snd-hda-codec-hdmi for SOF HDMI/DP support #1123

Closed
Closed
[enhancement] Use snd-hda-codec-hdmi for SOF HDMI/DP support#1123
Assignees
kv2019i
Labels
enhancementNew feature or requestreuse legacy HDMI codecReuse legacy HDA HDMI codec driver snd-hda-codec-hdmi

Description

@kv2019i
kv2019i
opened on Aug 12, 2019

There are currently two i915 HDMI codec implementations in upstream kernel, snd-hda-codec-hdmi (sound/pci/hda) and hdac_hdmi (sound/soc/codecs).

SOF is currently using the latter to enable HDMI/DP features for Intel HDA platforms.

Maintaining two codecs for the same hardware is not efficient as a fair amount of bugfixes and hw quirks are maintained for different hardware generations. And as of now, the snd-hda-codec-hdmi driver is much more widely used.

SOF should move to use the snd-hda-codec-hdmi driver as well and eventually to merge the drivers. SOF already reuses the HDAC library for HDA audio and HDMI/DP is programmed via HDA interface on the i915 hardware, so using this solution also for HDMI makes sense.

Activity

  1. kv2019i
    added
    enhancementNew feature or request
    on Aug 12, 2019
  2. kv2019i
    self-assigned this
    on Aug 12, 2019

  3. fredoh9 commented on Aug 12, 2019

    @fredoh9
    fredoh9
    on Aug 12, 2019
    Collaborator

    I'm attaching more logs for ICL HDA. This is not 100% reproducible, only sometimes I can see this failures.

    [    5.556801] sof-audio-pci 0000:00:1f.3: error: codec #1 probe error, ret: -5
[    5.556804] sof-audio-pci 0000:00:1f.3: Turning i915 HDAC power off
[    5.556957] sof-audio-pci 0000:00:1f.3: error: no matching ASoC machine driver found - aborting probe
[    5.556958] sof-audio-pci 0000:00:1f.3: error: failed to get machine info -19
[    5.556959] sof-audio-pci 0000:00:1f.3: error: sof_probe_work failed err: -19

    0809_icl6_hdmi_error.log
    0812_icl5_hdmi_error.log
    0812_icl5_no_soundcard.log
    0812_icl6_booting_ok.log

  4. mengdonglin
    added
    reuse legacy HDMI codecReuse legacy HDA HDMI codec driver snd-hda-codec-hdmi
    on Aug 26, 2019

  5. kv2019i commented on Aug 27, 2019

    @kv2019i
    kv2019i
    on Aug 27, 2019
    CollaboratorAuthor

    New patch series uploaded on #1155 -- see progress update in the PR description.

  6. kv2019i commented on Nov 4, 2019

    @kv2019i
    kv2019i
    on Nov 4, 2019
    CollaboratorAuthor

    This enhancement is now implemtend with #1404 and #1422

  7. kv2019i
    closed this as completedon Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementNew feature or requestreuse legacy HDMI codecReuse legacy HDA HDMI codec driver snd-hda-codec-hdmi

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions