Skip to content

[V8] Move to snd-hda-codec-hdmi for SOF HDMI/DP support - #1155

Closed
kv2019i wants to merge 13 commits into
thesofproject:topic/sof-devfrom
kv2019i:topic/hda-hdmi
Closed

kv2019i wants to merge 13 commits into
thesofproject:topic/sof-devfrom
kv2019i:topic/hda-hdmi

Conversation

@kv2019i

@kv2019i kv2019i commented Aug 23, 2019 •

Copy link
Copy Markdown
Collaborator

Here's patchset to move from hdac-hdmi to snd-hda-codec-hdmi to implement HDMI/DP support.
Two machine drivers (UP^2 with Hifiberry and generic HDA-audio) are updated as example.

Related patch to topology to align the PCM interface with legacy driver: TBD -> topology changes not needed after all

Implements #1123
Implements #1078
Fixes #1104
Fixes #1077
Fixes #1375

Event log:

  • V8 (WW44.2) v8 sent to alsa-devel -- a few more comments + sparse warnings
  • V7 (WW43.3) v7 sent to alsa-devel -- addressing Takashi's feedback on inline functions, rebased on Mark's tree
  • V6 (WW41.5) v6 sent to alsa-devel -- fixes [ICL] Resume from S3 fails with snd-hda-codec-hdmi #1263
  • V5 (WW39.3) v5 sent to alsa-devel -- fixed issue on ICL
  • V4 (WW37.4) v4 sent to alsa-devel -- addressed feedback to V3, fix to ICL support
  • V3 (WW37.2) v3 sent to alsa-devel -- addressed feedback to V2, extended series to cover all SOF/HDMI machine drivers, various smaller cleanups
  • V2 (WW35.5) v2 sent to alsa-devel -- implemented runtime selection of driver selection to support distribution kernels; various bugfies
  • V1/rc4 (WW35.4) added chmap support; patch sent upstream to alsa-devel
  • prelist-rc3 (WW35.3) dynamically parse PCM ids from topology at probe; multiple clean ups
  • prelist-rc2 (WW35.2) v2 patchset, added a mechanism to pass PCM device numbers from machine driver to HDA codec driver; lots of cleanups; tested with PA12.2; added support for skl-hda-generic-dsp
  • prelist-rc1 (WW34): initial patchset

Currently tested:

  • eld procfs is working with SOF
  • single-monitor playback is working
  • playback to different monitors is working (HDMI and DP)
  • concurrent playback to two monitors (HDMI+DP)
  • concurrent playback to three monitors (HDMI + 2xDP in MST mode)
  • jack detection works (as expected by e.g. Pulseaudio)
  • jack detection works without changing topology with Pulseaudio 12.x and newer

Open issues list: NONE, no open issues left

  • higher rate of failures on ICL in regression test -> fixed with V5 series WW39 and display driver patches WW40
  • concept of backup/virtual PCMs used by "dyn-pcm-assign" mode of hda-codec-hdmi does not work well with ASoC, SOF and topology
  • how do we pass the "SOF mode" info to hda-codec-hdmi? new hda-codec flag added
  • chmap ctl registration is broken
  • naming of some entities should be revisioted (e.g. get rid of the "hifiX" names) -> fixed in v2
  • plan needed how/which machine drivers to update (on need basis, or move over all)
  • compatibility of machine drivers with SST driver
  • test legacy driver works with the patch_hdmi.c modifications in this set

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

reuse legacy HDMI codec Reuse legacy HDA HDMI codec driver snd-hda-codec-hdmi upstream Patch has been sent to upstream (e.g. alsa-devel)

Projects

None yet

5 participants