Repository navigation
tenforce/virtuoso container:latest image seems to be failing builds regularly #136
Description
We're seeing build failures hitting the virtuoso module for a few days now:
- https://circleci.com/gh/testcontainers/testcontainers-java/517 - affects @outofcoffee's PR Adds pluggable wait strategy, and HTTP(S) implementation. #133
- https://circleci.com/gh/testcontainers/testcontainers-java/518 - affects @tbinias's PR add support for extra hosts to GenericContainer #135
- also on the
windows-supportbranch, which is a clean fork of a stable master branch
It looks like the latest image was changed six days ago: https://hub.docker.com/r/tenforce/virtuoso/tags/
I suspect the fact that the module is using the latest tag is a bad thing - perhaps there's an issue with this. I'll try and locate a stable named tag and get that into master ASAP.
@v-schulz are you aware of any problems with Virtuoso support from your own experience?
Activity
v-schulz commentedon Apr 24, 2016
@rnorth No, but currently I'm not working with the container. Sorry for the problems, I think tag 1.0.0-virtuoso7.2.0 should be fine.
rnorth commentedon Apr 24, 2016
@v-schulz no worries - I'll give that tag a try. Thanks
v-schulz commentedon Apr 24, 2016
Let me correct myself, tag virtuoso-v7.2.0-latest works fine for me. The one mentioned above throws the same error like in the builds you mentioned.
Resolve #136: Add a 5s stabilisation period for the launched Virtuoso…
rnorth commentedon Apr 24, 2016
@v-schulz thanks. I had similar issues with that one until adding a 5s 'stabilisation period' to the container object's liveness checks. I'm not quite sure what has changed in Virtuoso, but it seems it would consistently (a) respond OK to the 'SELECT 1' in the liveness check then (b) drop the next few connection attempts for <1s or so.
I've now made it so that the Virtuoso container has to respond to the SELECT 1 query consistently for 5 seconds. This seems to work.
I've tried this on a few of the available tags and it now works, so I've gone for 1.0.0-virtuoso7.2.2 as it seems to be the most recent.
This is all in PR #138
rnorth commentedon Apr 24, 2016
It seems this is still falling apart on CI so I'm going to disable the Virtuoso module for the time being. I think we need to bring the container image we use under our control to prevent this happening in the future.
I'd like to reinstate it before 1.0.5 release, but will evaluate depending on the relative importance of other features in 1.0.5.
Disable virtuoso module - see #136
Merge pull request #139 from testcontainers/disable-virtuoso
Resolve #136: Add a 5s stabilisation period for the launched Virtuoso…
Merge pull request #138 from testcontainers/fix-virtuoso