[tbinias]

Hi, we are using testcontainers in our project to run end2end tests with selenium. Our web application runs on a vagrant box and rely on host names for rendering different states.

I have added support for the extra hosts property of the docker API for a GenericContainer.

It would be nice if this change will find it's way into your project.

[tbinias]

The failing tests seams to be related to a missing virtuoso-rule. The test 'org.testcontainers.containers.VirtuosoJDBCDriverTest' also fails local on the master branch.

With the following patch tests are fine:
missing_rule_on_virtuoso_test.patch.txt

[rnorth]

Hi,
This sounds good - I'll have a quick look at the code, but this would be a good feature to have. Thank you!

Re the test failures, this seems quite odd. I'll try and reproduce, but basically the patch that worked for you shouldn't really have changed anything - the JDBC support doesn't use a JUnit rule (it instead uses a proxying JDBC driver). So perhaps this is some kind of coincidence. I'll look into it - the verbose logs in the virtuoso module probably make it hard to figure out what's going on too!

Thanks
Richard

[rnorth]

Is it just Github's rendering, or is this indented by a few too many spaces?

[tbinias]

Just forgot to change the indent to space in my workspace, sorry.

[rnorth]

I'm re-running the tests, as the build worked for me locally. Perhaps there was a temporary problem pulling the virtuoso container image and/or a problem with the image itself. I should separately stop the virtuoso container from using latest and instead use a tagged version.

[rnorth]

FWIW I'll accept this PR with only Travis CI passing, as the CircleCI builds are not receiving the patch on master to disable Virtuoso build. FYI @tbinias, when you're ready.

[tbinias]

@rnorth: I'm done.

[rnorth]

Great, looks good to me.
Thank you!