Skip to content

Refs #136: Add a stabilisation period for the launched Virtuoso container - #138

Merged
rnorth merged 2 commits into
masterfrom
fix-virtuoso
May 1, 2016
Merged

rnorth merged 2 commits into
masterfrom
fix-virtuoso

Conversation

@rnorth

@rnorth rnorth commented Apr 24, 2016

Copy link
Copy Markdown
Member

… as it seems newer versions of the base container are responding OK to the first 'SELECT 1' but then rejecting the subsequent query.

Lock down Virtuoso containers to a fixed tag rather than latest, unless specified.
Reduce verbosity of logs for Virtuoso tests.

@rnorth rnorth changed the title Resolve #136: Add a 5s stabilisation period for the launched Virtuoso container Refs #136: Add a stabilisation period for the launched Virtuoso container Apr 24, 2016
… container, as it seems newer versions of the base container are responding OK to the first 'SELECT 1' but then rejecting the subsequent query.

Lock down Virtuoso containers to a fixed tag rather than latest, unless specified.
Reduce verbosity of logs for Virtuoso tests.
Add fixed Virtuoso version to JDBC test
Update to latest version of duct-tape to allow use of fixed Inconsistents get
Reinstate virtuoso maven module
@rnorth

rnorth commented Apr 30, 2016

Copy link
Copy Markdown
Member Author

I think these changes should fix the problem, but now a new issue on CI:

[ERROR] Failed to execute goal on project virtuoso: Could not resolve dependencies for project org.testcontainers:virtuoso:jar:1.0.5-SNAPSHOT: Failed to collect dependencies at virtuoso:jdbc-driver:jar:4.0: Failed to read artifact descriptor for virtuoso:jdbc-driver:jar:4.0: Could not transfer artifact virtuoso:jdbc-driver:pom:4.0 from/to ldstack (http://mvn.linkeddata.org/content/groups/linkeddata.org/): Failed to transfer file: http://mvn.linkeddata.org/content/groups/linkeddata.org/virtuoso/jdbc-driver/4.0/jdbc-driver-4.0.pom. Return code is: 503 , ReasonPhrase:Service Unavailable. -> [Help 1]

If this third party maven repo stays down I think the Virtuoso module may have to take a pass on the next release :(

In the slightly longer term I'd like to try and decouple this dependency to avoid issues like this in the future. Not sure what the options are yet, though...

…hat it relies on a third party maven repository. This allows developer testing if the Virtuoso drivers are available, but does not couple CI to the availability of the drivers.
@rnorth

rnorth commented Apr 30, 2016

Copy link
Copy Markdown
Member Author

@v-schulz would you mind having a look at this and checking you're happy with the changes? I've put the Virtuoso module under the proprietary-deps maven profile like the Oracle-XE module, as it seems mvn.linkeddata.org is suffering some downtime. I'm inclined to keep it under this profile, unless the drivers are available in maven central.

As-is, the Virtuoso module is not validated by CI, just by local developer builds when running mvn clean install -Pproprietary-deps - same as for the Oracle module.

What do you think?

@v-schulz

v-schulz commented May 1, 2016

Copy link
Copy Markdown
Contributor

I think that's ok - especially because Virtuoso may not be the most important TestContainer available . Whoever wants to use it can easily activate the module. I didn't find a solution to the problem, neither, so we can stick to this.

@rnorth

rnorth commented May 1, 2016

Copy link
Copy Markdown
Member Author

@v-schulz thanks - I'll merge then!

FWIW it's basically just excluded from CI - it will still be published as a maven module so won't be hard to use for people who need it.

@rnorth
rnorth merged commit 8b08b2a into master May 1, 2016
@rnorth
rnorth deleted the fix-virtuoso branch June 10, 2016 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants