Repository navigation
pr: lift kendo branch-type gate and drop multi-runner glob - #26
Merged
Merged
Conversation
Lifted from kendo .claude/skills/pr (2026-08-26): - Step 1 fetches the base branch before any diff/log command. - Step 4 is a branch-type gate table: a plan directory reads REVIEW_CLAUDE.md and prompts for /review-branch; a bug directory reads BUG.md "## Verification" and never prompts for /review-branch. - Bug verdict rule: only the exact string PASS passes. FAIL, PARTIAL, BLOCKED and "PASS (requires developer confirmation)" block. Only the first Verdict line counts; superseded verdicts do not gate. A missing Verdict line blocks like a failing one. - Reviewer names in the blocker prompt and PR body are Runtime Integrity and Precedent. The PR body gains a "Bug Fix Verification" block. - The "Test plan" PR-body section is dropped, as kendo did. Removed per DECISIONS.md D4: the REVIEW_<RUNNER>.md glob, the cross-runner staleness listing, and the link to review-branch/references/review-file-format.md. That reference file is deleted here; this was its last link once PR #20 merges. Generalised: - origin/development -> origin/<base>, resolved by the existing gh / symbolic-ref command before the fetch. - IT-/KD- prefixes -> {{ISSUE_KEY_PREFIX}}-, project_id 1 -> {{PROJECT_ID}}. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UX7YHkAamvBe8Hh66f95b7
The previous commit staged only the reference-file deletion; the SKILL.md rewrite it describes is in this commit. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UX7YHkAamvBe8Hh66f95b7
jasperboerhof
added a commit
that referenced
this pull request
Sep 2, 2026
…allbacks Lifted from kendo (2026-07-27): steps 4-6 resolve against a <root>; new "Which root" section (docs/plans/ then docs/bugs/ for /review-branch, plans win on collision); /review-branch and /pr fallback lines match the docs/bugs/ support already merged in review-branch (#20) and pr (#26). Generalised: the issue-key example in step 5 uses {{ISSUE_KEY_PREFIX}}. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UX7YHkAamvBe8Hh66f95b7
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Kendo reworked
pron 2026-08-26 (f7a33a8a6c) around the reviewer pair and the bug-branch verdict gate. The catalog still globbedREVIEW_<RUNNER>.mdfiles and named the retired reviewers.Merge after #20 (
review-branch). That PR removes the other link to the reference file deleted here.What
REVIEW_CLAUDE.mdand prompts for/review-branch. A bug directory reads BUG.md## Verificationand never prompts for/review-branch.PASSpasses.FAIL,PARTIAL,BLOCKED, andPASS (requires developer confirmation)block. Only the first**Verdict:**line counts. Superseded verdicts do not gate. A missing verdict line blocks like a failing one.REVIEW_<RUNNER>.mdglob, the cross-runner staleness listing, and the link toreview-branch/references/review-file-format.md.skills/review-branch/references/review-file-format.md. Its sections (Acceptance, Simplicity, Silent Failure, Efficiency) described the retired pipeline. The format now lives inline inreview-branchStep 4 (PR review-branch: lift kendo reviewer-pair redesign #20).Generalised
origin/developmentbecameorigin/<base>, resolved by the existinggh pr view/symbolic-refcommand before the fetch.IT-/KD-prefixes became{{ISSUE_KEY_PREFIX}}-.project_id: 1became{{PROJECT_ID}}.gh pr create --base developmentbecame--base <base-branch>.Out of scope
fix-bugskill does not yet have Phase 8.5 or the 3c path this gate cites. Thefix-buglift in PLAN.md adds them.mcp__kendo__*tool names andkendo://resources stay. They name the MCP server, not the project.Test plan
grep -n 'REVIEW_\*\|REVIEW_<RUNNER>' skills/pr/SKILL.mdis emptygrep -rn -i 'kendo\|KD-[0-9]\|CRIT-\|script\.nl\|warroom\|war room\|phpstan\|knip' skills/pr/SKILL.mdhits onlymcp__kendo__tool names andkendo://resourcesgrep -rn 'acceptance-reviewer\|simplicity-reviewer\|silent-failure-hunter\|efficiency-hunter\|task-alignment-reviewer' skills/pr/SKILL.mdis empty🤖 Generated with Claude Code
https://claude.ai/code/session_01UX7YHkAamvBe8Hh66f95b7