Skip to content

review-branch: lift kendo reviewer-pair redesign - #20

Merged
jasperboerhof merged 1 commit into
mainfrom
lift/review-branch
Sep 2, 2026
Merged

jasperboerhof merged 1 commit into
mainfrom
lift/review-branch

Conversation

@jasperboerhof

Copy link
Copy Markdown
Contributor

Why

Kendo redesigned review-branch on 2026-07-27 (KD-1061, 79e77d0b) to spawn the always-on pair runtime-integrity-reviewer + precedent-reviewer. The catalog still spawned the retired five-agent pipeline.

What

  • Spawn runtime-integrity-reviewer and precedent-reviewer always, in parallel, on every branch. No trigger patterns, no conditional specialists.
  • Step 2 resolves docs/plans/<slug>/ first, then docs/bugs/<slug>/. On a bug branch the review is optional; bug-fix-verifier is the gate.
  • No-directory fallback still spawns both agents and reports in chat, writing nothing.
  • Step 1 no longer pulls the full diff into the orchestrator context.
  • The REVIEW_CLAUDE.md format is inlined in Step 4 with Runtime Integrity / Precedent sections, matching kendo.
  • Synthesis rules add the "Required Fixes Before PR means do not open a PR" calibration.

Generalised

  • origin/development became origin/{{DEFAULT_BRANCH}}.
  • "ADR projections in backend/CLAUDE.md and frontend/CLAUDE.md" became "the repo's standing rules (every CLAUDE.md, plus an ADR set where one exists)".
  • The .claude/REVIEWERS.md citation is dropped per DECISIONS.md D2. Each agent carries its own calibration text.
  • "kendo conventions" in the fallback became "the repo's conventions".

Out of scope

  • references/review-file-format.md still exists but is no longer linked from this skill. It is deleted in the follow-up pr PR, which removes the last link to it. Deleting it here would leave skills/pr/SKILL.md with a dangling link.
  • skills/plan-feature/references/plan-directory.md still says /review-branch skips the pipeline when no plan exists. Kendo updated that file with a "Which root" section. That file belongs to the plan-feature lift.

Test plan

  • grep -rn -i 'kendo\|KD-[0-9]\|CRIT-\|script\.nl\|warroom\|war room\|phpstan\|knip' skills/review-branch/SKILL.md is empty
  • grep -rn 'acceptance-reviewer\|simplicity-reviewer\|silent-failure-hunter\|efficiency-hunter\|task-alignment-reviewer' skills/review-branch/SKILL.md is empty
  • grep -n REVIEWERS skills/review-branch/SKILL.md is empty

🤖 Generated with Claude Code

https://claude.ai/code/session_01UX7YHkAamvBe8Hh66f95b7

Replace the five-agent pipeline (acceptance + simplicity, conditional
silent-failure / efficiency) with kendo's always-on pair:
runtime-integrity-reviewer + precedent-reviewer, spawned in parallel on
every branch. Lifted from kendo .claude/skills/review-branch (2026-07-27).

Lifted:
- "The two questions" section: one question per reviewer, no trigger
  patterns, no conditional specialists.
- Step 2 resolves docs/plans/<slug>/ first, then docs/bugs/<slug>/; the
  review is optional on bug branches (bug-fix-verifier is their gate).
- No-directory fallback still spawns both agents and reports in chat.
- Step 1 no longer pulls the full diff into the orchestrator.
- The REVIEW_CLAUDE.md format is inlined in Step 4 with Runtime Integrity
  / Precedent sections. Synthesis rules add the "Required Fixes means
  don't open a PR" calibration.

Generalised:
- origin/development -> origin/{{DEFAULT_BRANCH}}.
- "ADR projections in backend/CLAUDE.md and frontend/CLAUDE.md" -> "the
  repo's standing rules (every CLAUDE.md, plus an ADR set where one
  exists)".
- Dropped the .claude/REVIEWERS.md citation (DECISIONS.md D2); each agent
  carries its own calibration.

references/review-file-format.md is no longer linked from this skill. It
is deleted in the follow-up pr PR, which removes the last link to it.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UX7YHkAamvBe8Hh66f95b7
@jasperboerhof jasperboerhof added the Agent Review Requested Ask an agent to review this PR label Sep 2, 2026
@jasperboerhof
jasperboerhof merged commit ba9c12f into main Sep 2, 2026
1 check passed
jasperboerhof added a commit that referenced this pull request Sep 2, 2026
…allbacks

Lifted from kendo (2026-07-27): steps 4-6 resolve against a <root>; new
"Which root" section (docs/plans/ then docs/bugs/ for /review-branch,
plans win on collision); /review-branch and /pr fallback lines match the
docs/bugs/ support already merged in review-branch (#20) and pr (#26).

Generalised: the issue-key example in step 5 uses {{ISSUE_KEY_PREFIX}}.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UX7YHkAamvBe8Hh66f95b7
@jasperboerhof
jasperboerhof deleted the lift/review-branch branch September 7, 2026 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Agent Review Requested Ask an agent to review this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant