Skip to content

added wait method to AsyncParametersClient - #337

Closed
BrannonKing wants to merge 0 commit into
ros2:masterfrom
asirobots:master
Closed

BrannonKing wants to merge 0 commit into
ros2:masterfrom
asirobots:master

Conversation

@BrannonKing

Copy link
Copy Markdown

This is to help me with CoreDX where its clients/services are not ready immediately upon creation. See #330

@dirk-thomas

Copy link
Copy Markdown
Member

While trying to rebase your PR I screwed up the remote branch and this got closed. Since I can't change the remote branch anymore I created #342 which contain your patch in a branch in this repo. I will run some CI builds for it.

@dirk-thomas

Copy link
Copy Markdown
Member

@BrannonKing I think my attempt to rebase your PR has also reset the master branch of your fork (which is the branch used for this PR) to the current master upstream. I am sorry for the inconvenience. 😯

@dirk-thomas dirk-thomas added the enhancement New feature or request label Jul 7, 2017
DensoADAS pushed a commit to DensoADAS/rclcpp that referenced this pull request Aug 5, 2022
…os2#337)

* Add QoS to the GenericSubscription / GenericPublisher APIs

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
DensoADAS pushed a commit to DensoADAS/rclcpp that referenced this pull request Aug 5, 2022
DensoADAS pushed a commit to DensoADAS/rclcpp that referenced this pull request Aug 5, 2022
…e-do ros2#337) (ros2#340)

* Add QoS to the GenericSubscription / GenericPublisher APIs

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants