Skip to content

refactor to support multiple types and no_demangle - #339

Merged
wjwwood merged 2 commits into
masterfrom
refactor_get_topic_names_and_types
Jun 17, 2017
Merged

wjwwood merged 2 commits into
masterfrom
refactor_get_topic_names_and_types

Conversation

@wjwwood

@wjwwood wjwwood commented Jun 15, 2017

Copy link
Copy Markdown
Member

Connects to ros2/ros2#361

@wjwwood wjwwood added the in progress Actively being worked on (Kanban column) label Jun 15, 2017
@wjwwood wjwwood self-assigned this Jun 15, 2017

RCLCPP_PUBLIC
std::map<std::string, std::string>
std::map<std::string, std::vector<std::string>>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't a set make more sense here?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll ticket this.

@wjwwood wjwwood added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Jun 16, 2017
@wjwwood
wjwwood merged commit 5a99bbd into master Jun 17, 2017
@wjwwood
wjwwood deleted the refactor_get_topic_names_and_types branch June 17, 2017 01:03
@wjwwood wjwwood removed the in review Waiting for review (Kanban column) label Jun 17, 2017
nnmm pushed a commit to ApexAI/rclcpp that referenced this pull request Jul 9, 2022
DensoADAS pushed a commit to DensoADAS/rclcpp that referenced this pull request Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants