Skip to content

Remove a constructor that we can't test. - #340

Merged
clalancette merged 1 commit into
masterfrom
remove-bad-constructor
Jun 21, 2017
Merged

clalancette merged 1 commit into
masterfrom
remove-bad-constructor

Conversation

@clalancette

@clalancette clalancette commented Jun 15, 2017 •

Copy link
Copy Markdown
Contributor

There are currently no paths that lead to it, and it has
a bug anyway; if a large enough value is passed into sec,
then we will overflow sec on the multiply. Just remove it
since we can't reach the code anyway.

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

There are currently no paths that lead to it, and it has
a bug anyway; if a large enough value is passed into sec,
then we will overflow sec on the multiply.  Just remove it
since we can't reach the code anyway.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@clalancette clalancette added in progress Actively being worked on (Kanban column) in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Jun 15, 2017
@clalancette

Copy link
Copy Markdown
Contributor Author

As suggested by @wjwwood , run a CI job to make sure nothing in the turtlebot demo uses this:

  • TB2 Linux Build Status

@clalancette

Copy link
Copy Markdown
Contributor Author

Approved, and this is building on all arches + TB2. Merging, thanks!

@clalancette
clalancette merged commit b8d72d6 into master Jun 21, 2017
@clalancette clalancette removed the in review Waiting for review (Kanban column) label Jun 21, 2017
@clalancette
clalancette deleted the remove-bad-constructor branch June 21, 2017 13:24
nnmm pushed a commit to ApexAI/rclcpp that referenced this pull request Jul 9, 2022
* update test to IDL-based action generation

* update test to IDL-based action generation

* fix merge conflict

* update new tests

* update action types

* match renamed action types

* style fix

* update types using unique_identifier_msgs
DensoADAS pushed a commit to DensoADAS/rclcpp that referenced this pull request Aug 5, 2022
…e-do ros2#337) (ros2#340)

* Add QoS to the GenericSubscription / GenericPublisher APIs

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants