Repository navigation
issue #463 - #584
Closed
Gaurang033 wants to merge 34 commits into
Closed
issue #463#584Gaurang033 wants to merge 34 commits into
Gaurang033 wants to merge 34 commits into
Conversation
…ssue robotframework#463 table_cell_should_not_contain table_column_should_not_contain table_footer_should_not_contain table_header_should_not_contain table_row_should_not_contain table_should_not_contain
Contributor
|
Would it make more sense to collapse all of those keywords down to a single On Tue, Mar 8, 2016 at 1:06 PM, Gaurang Shah notifications@github.com
|
Contributor
Author
|
@boakley There are already multiple keywords for Table/Cell/Row/Column Should Contain. And so I thought it would be better to have their corresponding Should Not Contain keyword, rather than clubbing them. Clubbing them might create confusion. |
Contributor
Author
|
is anyone going to merge this ? |
Contributor
|
One pull request must solve only a one problem. Please create separate pull request for the #673 issue. |
While we are not having Selenium 3.0 working, with external `geckodriver`, we use lower versions of stable Firefox.
We are not ready for Selenium 3.0 yet.
…ssue robotframework#463 table_cell_should_not_contain table_column_should_not_contain table_footer_should_not_contain table_header_should_not_contain table_row_should_not_contain table_should_not_contain
Since Selenium version 2.53.0 deselect_by_value/label returns boolean, and Exception if element is not found. This fix keeps compatibility with versions <=2.52.0.
Revert setup.py and doc/Selenium2Library.html to previous version. Check Edge compatibility of Selenium webdriver.
The docutils is only needed for Selenium2Library development, therefore removed the dependency from setup.py. Also added meaningfull error message to development tools, if the docutils is not installed.
…amework#630) * Fixes robotframework#629 by expecting NoSuchElementException Empty expect are not coding practices. The deselect_by_value and the deselect_by_visible_text raises NoSuchElementException if it can not deselect the items.
This hopefully allows github serve library documentation without using separate gh-pages branch. More details: https://help.github.com/articles/configuring-a-publishing-source-for-github-pages/
This is served when accessing http://robotframework.org/Selenium2Library/. Contains links to keyword docs and other related info.
Github renders *.rst files automatically and there is not needed create separate files.
Use project from https://bitbucket.org/robotframework/webdemo because it has better documentation and usage possibilities.
* 2to3.py runned for print & except * 2to3.py runned for except * 2to3.py -f dict
…botframework#660) * Remove vendored mockito and list in requirements-dev.txt instead. There absolutely no need for us to keep an old copy of mockito when it can be easily pip installed. This also removes the need to make our copy Python 3 compatible. * Install mockito on travis (and don't install docutils)
Eases installing project requirements e.g. when doing development. To avoid listing requirements twice, changed setup.py to read install_requires content from requirements.txt directly.
Finding unit tests is rewritten by using test discovery functionality provided by the unittest module in Python 2.7 and newer. This means unit tests cannot be executed with Python 2.6 anymore, but we've decided to drop its support anyway (robotframework#620). Tests won't be run with Python 2.6 on Travis anymore either. Also removed utils related to loading modules from S2L.utils. This unit test related code didn't belong under the main project in the first place.
* Improves alert hadling for Chrome (robotframework#652) In Chrome is often a random WebDriverException which caused by unknow reson. This commit creates a retry functionality that improves alert handling for Crome. Fixes robotframework#652 * Refactored the code to simplify the logic * Changed class attribute to better describe what it does * Updates alert handling based on the comment review * Changed class atributes names to describe better what they do * Fixed based on the comments
* Fix 404 due to RF migration to Github * Link to project page * Format corrections per PR comments * fix pronoun usage
While we are not having Selenium 3.0 working, with external `geckodriver`, we use lower versions of stable Firefox.
We are not ready for Selenium 3.0 yet.
Contributor
Author
|
is anyone going to merge this pull request? |
Contributor
|
Sorry for long delay. Not with that history. Could you clean the commit history that it contains only the commits relevant to this PR. Most likely it is easiest to open new branch from S2L master and cherry pick the current commits and then send new PR. |
Contributor
Author
|
I will delete the existing pull request and will create the new one.
Gaurang Shah
Blog: AutomationTesting.co.in <http://automationtesting.co.in>
Mobile: +91 7387756556
…On Thu, Dec 29, 2016 at 9:41 PM, Tatu Aalto ***@***.***> wrote:
Sorry for long delay.
Not with that history. Could you clean the commit history that it contains
only the commits relevant to this PR. Most likely it is easiest to open new
branch from S2L master and cherry pick the current commits and then send
new PR.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/robotframework/Selenium2Library/pull/584#issuecomment-269690280>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACf7ZVM7ilVdV-Hk89HHPP8ffxMi8m6Dks5rNBr5gaJpZM4HsDF8>
.
|
Contributor
Author
|
Will create the new pull request for this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added following keyword and their corresponding test cases to fix the issue #463